Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use S.true in the conditions in integral transforms #14695

Merged
merged 2 commits into from Aug 3, 2018

Conversation

asmeurer
Copy link
Member

@asmeurer asmeurer commented May 3, 2018

S.true should be used anywhere that a full symbolic condition can be used,
which is the case. Among other things, this makes transforms with
noconds=False pretty print properly, as the _can_print_latex ignores bool.

  • integrals
    • fix pretty printing of integral transforms noconds=False

S.true should be used anywhere that a full symbolic condition can be used,
which is the case. Among other things, this makes transforms with
noconds=False pretty print properly, as the _can_print_latex ignores bool.
@sympy-bot
Copy link

sympy-bot commented Jul 23, 2018

Hi, I am the SymPy bot (v123). I'm here to make sure this pull request has a release notes entry. Please read the guide on how to write release notes.

Click here to see the pull request description that was parsed.

S.true should be used anywhere that a full symbolic condition can be used,
which is the case. Among other things, this makes transforms with
noconds=False pretty print properly, as the _can_print_latex ignores bool.

<!-- BEGIN RELEASE NOTES -->
- integrals
  * fix pretty printing of integral transforms `noconds=False`

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.2.1.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Update

The release notes on the wiki have been updated.

@cbm755
Copy link
Contributor

cbm755 commented Jul 26, 2018

I'm wondering if I should do it in meijreint too.

I can try to review but can you give an example (or a test)? I get the same results for pprint(Piecewise((6, Eq(im(z), 0)), (42, true))) and pprint(..., True)))

@asmeurer
Copy link
Member Author

I think it only affects the LaTeX printing in the notebook.

@smichr
Copy link
Member

smichr commented Jul 31, 2018

Any reason not to use S.true instead of S(True)?

@asmeurer
Copy link
Member Author

I don't know why I did that.

@smichr
Copy link
Member

smichr commented Aug 3, 2018

+1

@asmeurer asmeurer merged commit 943ab40 into sympy:master Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants