Add float sanitization to xlim and ylim in plot #15265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs
Fixes #15261
Brief description of what is fixed or changed
I found that the issue had been caused by sympy number types directly passed to matplotlib's backend, and getting checked by numpy's
isfinite()
, which cannot handle sympy's numbers.Any sympy's constants, or sympified numbers passed into plot's
xlim
andylim
would repeat the issue in this context.I think every sympy's numbers should be sanitized into python default
float
type, before passed into matplotlib backend.And also, I had added
is_real
check andis_finite
check, to make sure thatfloat()
can be safely applied to, and to implement numpy'sisfinite()
check in sympy's own way.I think
range
parameter has implicit way of sanitizing sympy's types unlikexlim
orylim
,so that the method could possibly be a workaround for original poster.
Other comments
Release Notes
xlim
andylim
fromplot()
not properly handling sympy's number classes.