added the fold_frac_powers and fold_short_frac flag to mathml printer #16075

shubhamabhang77 · 2019-02-26T08:45:20Z

References to other Issues or PRs

Brief description of what is fixed or changed

Added the Fold_frac_powers and fold_short_frac flags to the mathml presentation printer

Other comments

Release Notes

printing
- Added the Fold_frac_powers and fold_short_frac flags to the mathml presentation printer

sympy-bot · 2019-02-26T08:45:31Z

✅

Hi, I am the SymPy bot (v142). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

printing
- Added the Fold_frac_powers and fold_short_frac flags to the mathml presentation printer (#16075 by @shubhamabhang77)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.4.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed

- Added the Fold_frac_powers and fold_short_frac flags to the mathml presentation printer

#### Other comments


#### Release Notes


<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
- printing 

    - Added the Fold_frac_powers and fold_short_frac flags to the mathml presentation printer
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

shubhamabhang77 · 2019-02-26T08:53:53Z

I haven't added the test cases till now. Once all changes are made then I will add them.

oscargus · 2019-02-26T12:06:27Z

sympy/printing/mathml.py

@@ -554,6 +554,8 @@ def multiply(expr, mrow):
            numer, denom = fraction(expr)
            if denom is not S.One:
                frac = self.dom.createElement('mfrac')
+                if self._settings["fold_short_frac"]:


Should one make some sort of length test here? Or does one already know that the length is short?

Oh right. I forgot it there.

oscargus · 2019-02-26T12:08:48Z

sympy/printing/mathml.py

-            x.appendChild(self._print(e.exp))
-            return x
+        if e.exp.is_negative:
+            if self._settings['fold_short_frac'] and len(str(e.base)) < 3:


Can you please provide an example of MathML code generated from this part of the code? I cannot really figure out what it looks like (and when this happens).

In [3]: a= 1/(x) In [4]: print_mathml(a, printer='presentation', fold_short_frac=True) <mfrac bevelled="true"> <mn>1</mn> <msup> <mrow> <mfenced> <mi>x</mi> </mfenced> </mrow> <mn>1</mn> </msup> </mfrac>

Is this how you want?

Thanks!

I am not sure if this should happen or not. Well, this particular example shouldn't happen, but in general.

Here, you will need to check if the exponent is one and in that case not print the exponent, now it looks like

There is a method in another PR to check if there should be brackets around the expression, now maybe one could check if it e.base is Symbol and if it is not print the bracket.

Which PR is that to check for e.base is Symbol ? or to check for brackets?

The bracket check is actually merged. I didn't realize that (I have two outstanding PRs on this and I though it was in one of those). See #16069

I have also realized that the behavior of the MathML Rational is completely different to the LaTeX one, so as long as the 1-exponent is not printed I think this would be good to go for now. One can always come back and make it more like the LaTeX one if that is preferred.

oscargus · 2019-02-26T12:09:42Z

I think it looks good! Just some minor comments for now. Please add some tests as it will be easier to see the effect of the change then.

asmeurer · 2019-02-26T18:59:50Z

sympy/printing/mathml.py

@@ -554,6 +554,9 @@ def multiply(expr, mrow):
            numer, denom = fraction(expr)
            if denom is not S.One:
                frac = self.dom.createElement('mfrac')
+                print(expr)


Remove this.

Ohh sorry. That was by mistake. It was just for testing purpose.

…l type

oscargus · 2019-02-27T10:15:31Z

sympy/printing/mathml.py

+                    mrow.appendChild(self._print(e.base))
+                    frac.appendChild(mrow)
+                    return frac
+                if type(e.base) == symbol.Symbol:


I realized that you can do e.base.is_symbol (correct syntax would otherwise by e.base is Symbol).

Ohh Yeah. It's working.

shubhamabhang77 · 2019-03-02T12:52:14Z

Can Anyone merge this PR? I want to make another PR.

oscargus · 2019-03-02T12:56:24Z

I think the added functionality makes sense. A problem is that the original MathML printer is inconsistent with the LaTeX printer.

Hence, I merge this for now.

@shubhamabhang77 it makes sense to always start a new branch/PR/functionality from master, unless you are actually using some code from a previous PR. There may still be some issues with the other PR even after merging this.

shubhamabhang77 · 2019-03-02T13:04:25Z

I think the added functionality makes sense. A problem is that the original MathML printer is inconsistent with the LaTeX printer.

Hence, I merge this for now.

@shubhamabhang77 it makes sense to always start a new branch/PR/functionality from master, unless you are actually using some code from a previous PR. There may still be some issues with the other PR even after merging this.

Tell me if there are any changes that has to be.

oscargus · 2019-03-02T13:20:18Z

I wil try to prepare some things related to that now that the functionality is in. The main thing is really that the LaTeX and MathML presentation printers prints things like 1/y**2 differently. But that is really nothing that affects this PR.

shubhamabhang77 · 2019-03-02T13:44:01Z

I think the added functionality makes sense. A problem is that the original MathML printer is inconsistent with the LaTeX printer.

Hence, I merge this for now.

@shubhamabhang77 it makes sense to always start a new branch/PR/functionality from master, unless you are actually using some code from a previous PR. There may still be some issues with the other PR even after merging this.

I made another branch but I don't know what happened when I opened another PR, commits from PR was also listed there.

added the fold_frac_powers and fold_short_frac flag to mathml printer

e6340a3

oscargus reviewed Feb 26, 2019

View reviewed changes

oscargus added printing printing.mathml labels Feb 26, 2019

oscargus mentioned this pull request Feb 26, 2019

Add support for configuration of the MathML printers #15877

Open

added test cases and some minor changes

1ac6731

asmeurer reviewed Feb 26, 2019

View reviewed changes

shubhamabhang77 added 2 commits February 27, 2019 05:47

removed unnecessary content

f0460f3

checking if exponent is one and checking if e.base is of symbol.Symbo…

4757c55

…l type

oscargus reviewed Feb 27, 2019

View reviewed changes

shubhamabhang77 added 2 commits February 27, 2019 18:54

changes made in checking condition of symbol for brackets

e5225b5

some minor changes made

7fa4892

oscargus merged commit b786c99 into sympy:master Mar 2, 2019

shubhamabhang77 deleted the configuration_fold_frac_powers_and_fold_short_frac branch March 2, 2019 13:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added the fold_frac_powers and fold_short_frac flag to mathml printer #16075

added the fold_frac_powers and fold_short_frac flag to mathml printer #16075

shubhamabhang77 commented Feb 26, 2019 •

edited

sympy-bot commented Feb 26, 2019 •

edited

shubhamabhang77 commented Feb 26, 2019

oscargus Feb 26, 2019

shubhamabhang77 Feb 26, 2019

oscargus Feb 26, 2019

shubhamabhang77 Feb 26, 2019 •

edited

oscargus Feb 26, 2019

shubhamabhang77 Feb 27, 2019

oscargus Feb 27, 2019

oscargus commented Feb 26, 2019

asmeurer Feb 26, 2019

shubhamabhang77 Feb 27, 2019 •

edited

oscargus Feb 27, 2019

shubhamabhang77 Feb 27, 2019

shubhamabhang77 commented Mar 2, 2019

oscargus commented Mar 2, 2019

shubhamabhang77 commented Mar 2, 2019

oscargus commented Mar 2, 2019

shubhamabhang77 commented Mar 2, 2019

added the fold_frac_powers and fold_short_frac flag to mathml printer #16075

added the fold_frac_powers and fold_short_frac flag to mathml printer #16075

Conversation

shubhamabhang77 commented Feb 26, 2019 • edited

References to other Issues or PRs

Brief description of what is fixed or changed

Other comments

Release Notes

sympy-bot commented Feb 26, 2019 • edited

shubhamabhang77 commented Feb 26, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shubhamabhang77 Feb 26, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oscargus commented Feb 26, 2019

Choose a reason for hiding this comment

shubhamabhang77 Feb 27, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shubhamabhang77 commented Mar 2, 2019

oscargus commented Mar 2, 2019

shubhamabhang77 commented Mar 2, 2019

oscargus commented Mar 2, 2019

shubhamabhang77 commented Mar 2, 2019

shubhamabhang77 commented Feb 26, 2019 •

edited

sympy-bot commented Feb 26, 2019 •

edited

shubhamabhang77 Feb 26, 2019 •

edited

shubhamabhang77 Feb 27, 2019 •

edited