Added code to check summation of convergent series #16266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#Fixes 14579 Sum(sqrt(n), (n, 1, oo)) didn't calculate or simplified previously.It gave only its corresponding symbolic representation.As discussed in the issue thread,positive divergent series should return oo. Fixed in line 203-204.
Add some tests for issue_16250
Divergent summation series
|
✅ Hi, I am the SymPy bot (v142). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like: This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.4. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed. |
Divergent summation series
|
It would have been better to continue in #16250 as there you had got it into a separate branch, not on your master. |
|
yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14579
Brief description of what is fixed or changed
I have added code in eval_sum to check if the series is convergent and do calculations specifically.
I have added some tests.
Other comments
Ihaven't added added any code to fix or check and calculate sum for floating point integers.If granted I will add it.For now,only symbolically we can calculate.
Release Notes