Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2832 - WIP #1646

Merged
merged 1 commit into from
Aug 7, 2013
Merged

Issue 2832 - WIP #1646

merged 1 commit into from
Aug 7, 2013

Conversation

rlamy
Copy link
Member

@rlamy rlamy commented Nov 12, 2012

I'm trying to resolve issue 2832. Letting bool(Relational) raise a TypeError reveals a number of presumably incorrect uses of Relational objects.

Obviously, this cannot be merged at this stage. I'll open another PR for the fixes.

@asmeurer
Copy link
Member

Glad to see someone finally taking this on. My guess is that many of the errors will be not so much from an incorrect use of relationals as just an incorrect assumption that the variables are numeric.

@asmeurer
Copy link
Member

The actual AssertionError in the test failures is a little troubling. I guess somewhere is catching too many exceptions.

@rlamy rlamy mentioned this pull request Nov 12, 2012
@asmeurer
Copy link
Member

SymPy Bot Summary: 🔴 Failed after merging rlamy/Relational (e8c9f386425a99f3e42d885f3e1dfe4d489b2f33) into master (d383cd9).
@rlamy: Please fix the test failures.
🔴 Python 2.5.0-final-0: fail
🔴 Python 2.6.6-final-0: fail
🔴 Python 2.7.2-final-0: fail
🔴 Python 2.6.8-final-0: fail
🔴 Python 2.7.3-final-0: fail
🔴 PyPy 1.9.1-dev-0; 2.7.3-final-42: fail
🔴 Python 3.2.2-final-0: fail
🔴 Python 3.3.0-final-0: fail
🔴 Python 3.2.3-final-0: fail
🔴 Python 3.3.0-final-0: fail
🔴 Python 3.3.0-final-0: fail
✳️Sphinx 1.1.3: pass

@jrioux
Copy link
Member

jrioux commented Nov 14, 2012

SymPy Bot Summary: 🔴 Failed after merging rlamy/Relational (79a0cc78425fca2780df41b582ca0645ee1df553) into master (6f4dd72).
@rlamy: Please fix the test failures.
🔴 PyPy 1.9.1-dev-0; 2.7.3-final-42: fail
🔴 Python 2.7.2-final-0: fail
🔴 Python 3.2.1-final-0: fail
✳️ Sphinx 1.1.3: pass

@jrioux
Copy link
Member

jrioux commented Nov 20, 2012

SymPy Bot Summary: 🔴 Failed after merging rlamy/Relational (79a0cc78425fca2780df41b582ca0645ee1df553) into master (211f0f7).
@rlamy: Please fix the test failures.
🔴 Python 2.7.2-final-0: fail
🔴 Python 3.2.1-final-0: fail
✳️ Sphinx 1.1.3: pass

@rlamy
Copy link
Member Author

rlamy commented Nov 23, 2012

Rebased after merging #1647. There are still many failures.

@jrioux
Copy link
Member

jrioux commented Feb 18, 2013

SymPy Bot Summary: 🔴 Failed after merging rlamy/Relational (2e35061) into master (0308061).
@rlamy: Please fix the test failures.
🔴 PyPy 2.0.0-beta-1; 2.7.3-final-42: fail
🔴 Python 2.7.2-final-0: fail
🔴 Python 3.2.1-final-0: fail
✳️ Sphinx 1.1.3: pass
Docs build command: make clean && make html-errors && make latex && cd _build/latex && xelatex sympy-*.tex

@asmeurer
Copy link
Member

SymPy Bot Summary: 🔴 Failed after merging rlamy/Relational (2e35061) into master (34137fa).
@rlamy: Please fix the test failures.
🔴 Python 2.5.6-final-0: fail
🔴 Python 2.6.8-final-0: fail
🔴 Python 2.7.3-final-0: fail
🔴 Python 3.2.3-final-0: fail
✳️ Sphinx 1.1.3: pass

@asmeurer
Copy link
Member

SymPy Bot Summary: ✅ Passed after merging rlamy/Relational (2e35061) into master (00a0a1e).
Sphinx 1.2b1: pass
Doc Coverage: unchanged
36.58% of functions have doctests (compared to 36.58% in master)
40.97% of functions are imported into Sphinx (compared to 40.97% in master)

jrioux added a commit that referenced this pull request Aug 7, 2013
Relational: bool(Relational) should raise

Continuation of #1646. See issue 2832.
@jrioux jrioux merged commit 2e35061 into sympy:master Aug 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants