-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 2832 - WIP #1646
Issue 2832 - WIP #1646
Conversation
Glad to see someone finally taking this on. My guess is that many of the errors will be not so much from an incorrect use of relationals as just an incorrect assumption that the variables are numeric. |
The actual AssertionError in the test failures is a little troubling. I guess somewhere is catching too many exceptions. |
SymPy Bot Summary: 🔴 Failed after merging rlamy/Relational (e8c9f386425a99f3e42d885f3e1dfe4d489b2f33) into master (d383cd9). |
Rebased after merging #1647. There are still many failures. |
SymPy Bot Summary: 🔴 Failed after merging rlamy/Relational (2e35061) into master (0308061). |
Relational: bool(Relational) should raise Continuation of #1646. See issue 2832.
I'm trying to resolve issue 2832. Letting bool(Relational) raise a TypeError reveals a number of presumably incorrect uses of Relational objects.
Obviously, this cannot be merged at this stage. I'll open another PR for the fixes.