Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify before testing convergence #16739

Closed
wants to merge 8 commits into from
Closed

Simplify before testing convergence #16739

wants to merge 8 commits into from

Commits on Apr 27, 2019

  1. Simplify before testing convergence 

    Added simplification of function, before testing for convergence and added tests. Fixed sympy#16699.
    @AnimeshSinha1309
    AnimeshSinha1309 committed Apr 27, 2019
    Copy the full SHA
    c46395e View commit details
    Browse the repository at this point in the history

Commits on May 30, 2019

  1. Revert "Simplify before testing convergence" 

    This reverts commit c46395e.
    @AnimeshSinha1309
    AnimeshSinha1309 committed May 30, 2019
    Copy the full SHA
    d506c8d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into issue/convergence-16699 

    Update the master to the current state and restart on the issue.
    @AnimeshSinha1309
    AnimeshSinha1309 committed May 30, 2019
    Copy the full SHA
    e3984ae View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2019

  1. Fixed issue by limit-comparison with P-series 

    Changed the is_convergent() method to test limit comparison against 1/n and 1/n**1.0001, fixing the convergence test problem, though not the sharp order problem.
    @AnimeshSinha1309
    AnimeshSinha1309 committed Jul 3, 2019
    Copy the full SHA
    18e9b8b View commit details
    Browse the repository at this point in the history

  2. Typo fix 

    The previous commit forgot to call the function is_convergent in the tests, missing out the brackets. Fixing that here.
    @AnimeshSinha1309
    AnimeshSinha1309 committed Jul 3, 2019
    Copy the full SHA
    993896f View commit details
    Browse the repository at this point in the history

  3. Fixing for Tests 

    Some tests fixed, some code. Changed some tests that seem most certainly wrong, esp. an example.
    @AnimeshSinha1309
    AnimeshSinha1309 committed Jul 3, 2019
    Copy the full SHA
    7bc059d View commit details
    Browse the repository at this point in the history

  4. Both sides of 0 

    Handling the negative constant, fixing what I thought was an erroneous test and changed.
    @AnimeshSinha1309
    AnimeshSinha1309 committed Jul 3, 2019
    Copy the full SHA
    5dea881 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2019

  1. Fix a test 

    Issue sympy#14488 is no longer raising a NotImplementedError due to the limit being evaluated correctly.
    @AnimeshSinha1309
    AnimeshSinha1309 committed Jul 4, 2019
    Copy the full SHA
    ce6326e View commit details
    Browse the repository at this point in the history