New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solves issue with Range 16817 #16820
Conversation
✅ Hi, I am the SymPy bot (v147). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.5. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
Looks good; even better with a test from the issue which raised an error in master. |
Codecov Report
@@ Coverage Diff @@
## master #16820 +/- ##
=============================================
+ Coverage 73.847% 73.855% +0.007%
=============================================
Files 619 619
Lines 159669 159669
Branches 37476 37476
=============================================
+ Hits 117912 117924 +12
+ Misses 36297 36280 -17
- Partials 5460 5465 +5 |
@smichr Please review this. |
already did :-) |
a good non-latex test would be just |
@smichr I have added the test, please let me know if anything else is needed. |
+1; |
References to other Issues or PRs
Fixes #16817
Brief description of what is fixed or changed
Replaces 0 with S.Zero and 1 with S.One in
sympy/sets/fancysets.py
Latex is now giving correct results.
Other comments
Release Notes