Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sphinx build fail #16948

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Fix sphinx build fail #16948

merged 1 commit into from
Jun 3, 2019

Conversation

sylee957
Copy link
Member

@sylee957 sylee957 commented Jun 3, 2019

References to other Issues or PRs

Fixes #16945

Brief description of what is fixed or changed

Maybe the sphinx had become more strict about having duplicate .. module:: directive.
Using currentmodule instead of module may fix.
https://www.sphinx-doc.org/en/2.0/usage/restructuredtext/domains.html#directive-py:currentmodule

Other comments

Release Notes

NO ENTRY

@sympy-bot
Copy link

Hi, I am the SymPy bot (v147). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->
Fixes #16945

#### Brief description of what is fixed or changed

Maybe the sphinx had become more strict about having duplicate `.. module::` directive.
Using `currentmodule` instead of module may fix.
https://www.sphinx-doc.org/en/2.0/usage/restructuredtext/domains.html#directive-py:currentmodule 

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

Merging #16948 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master    #16948   +/-   ##
=========================================
  Coverage   73.928%   73.928%           
=========================================
  Files          620       620           
  Lines       160341    160341           
  Branches     37623     37623           
=========================================
  Hits        118538    118538           
- Misses       36310     36313    +3     
+ Partials      5493      5490    -3

@jksuom
Copy link
Member

jksuom commented Jun 3, 2019

This looks good to me.

@jksuom jksuom merged commit 5a13601 into sympy:master Jun 3, 2019
@sylee957 sylee957 deleted the fix_sphinx_fail branch June 3, 2019 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sphinx build failing
3 participants