Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC] Implemented convolution operation of two formal power series #17017
[GSoC] Implemented convolution operation of two formal power series #17017
Changes from 3 commits
5e5c732
1a2b0a7
b3616bd
28e6970
15a1817
8ed575b
b91c21b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this return the product of two power series? If so, then I think that the method should be renamed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes currently it does that. But if we implement other types of convolution like
dyadic
orcyclic
convolution, then they are no longerproduct
of two power series. So I think, we should keep itconvolute
. I will try to extend the code to integrate cyclic, dyadic and other types of convolution into it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ArighnaIITG ,
How do you plan to add new types of convolution in the future?
If they will be separate methods, I believe renaming it to product is good like @jksuom suggested.
or one way will be to allow a
method
kwarg, eg.f1.convolve(f2, method='linear')
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.