Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for LogNormal distribution #17068

Merged
merged 2 commits into from Jun 22, 2019

Conversation

ritesh99rakesh
Copy link
Member

References to other Issues or PRs

From #17057: When using scipy for sampling from LogNormal distribution, it is giving domain error since one of the tests is using std = 0. But std > 0.

Brief description of what is fixed or changed

Added check condition for positive std.

Other comments

Release Notes

  • stats
    • added check condition for LogNormal distribution.

@sympy-bot
Copy link

sympy-bot commented Jun 22, 2019

Hi, I am the SymPy bot (v147). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.5.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->
From https://github.com/sympy/sympy/pull/17057: When using `scipy` for sampling from `LogNormal` distribution, it is giving domain error since one of the tests is using `std = 0`. But `std > 0`.

#### Brief description of what is fixed or changed
Added check condition for positive `std`.

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
- stats
    - added check condition for `LogNormal` distribution.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@ritesh99rakesh
Copy link
Member Author

Ping @sidhantnagpal

@codecov
Copy link

codecov bot commented Jun 22, 2019

Codecov Report

Merging #17068 into master will increase coverage by 0.012%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##            master    #17068       +/-   ##
=============================================
+ Coverage   74.411%   74.423%   +0.012%     
=============================================
  Files          622       622               
  Lines       160930    160932        +2     
  Branches     37784     37784               
=============================================
+ Hits        119751    119772       +21     
+ Misses       35858     35838       -20     
- Partials      5321      5322        +1

Copy link
Member

@sidhantnagpal sidhantnagpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

sympy/stats/tests/test_continuous_rv.py Outdated Show resolved Hide resolved
@sidhantnagpal sidhantnagpal merged commit 2301d79 into sympy:master Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants