Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify tests Expr.is_zero before _eval_simplify #17110

Merged
merged 1 commit into from Jun 27, 2019
Merged

Conversation

smichr
Copy link
Member

@smichr smichr commented Jun 27, 2019

References to other Issues or PRs

fixes #7971 by adding a test for is_zero in the simplification routine
closes #17088

This only returns 0 for an object that is zero which,
when multiplied by zero, gives 0 (not an object like
Matrix.zeros(2).

Release Notes

  • simplify
    • simplify tests for Expr.is_zero

This only returns 0 for an object that is zero which,
when multiplied by zero, gives 0 (not an object like
Matrix.zeros(2).
@sympy-bot
Copy link

sympy-bot commented Jun 27, 2019

Hi, I am the SymPy bot (v147). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.5.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->

fixes #7971 by adding a test for `is_zero` in the simplification routine
closes #17088

This only returns 0 for an object that is zero which,
when multiplied by zero, gives 0 (not an object like
Matrix.zeros(2).

#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
- simplify
    - simplify tests for Expr.is_zero
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #17110 into master will decrease coverage by 0.013%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##            master    #17110       +/-   ##
=============================================
- Coverage   74.498%   74.484%   -0.014%     
=============================================
  Files          623       623               
  Lines       161217    161219        +2     
  Branches     37846     37847        +1     
=============================================
- Hits        120104    120083       -21     
- Misses       35787     35810       +23     
  Partials      5326      5326

@smichr smichr merged commit 26aa686 into sympy:master Jun 27, 2019
@smichr smichr deleted the 7971 branch June 27, 2019 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting simplify to simplify \integral 0
2 participants