Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sympify eq in diophantine #18201

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Conversation

oscarbenjamin
Copy link
Contributor

@oscarbenjamin oscarbenjamin commented Jan 2, 2020

References to other Issues or PRs

Brief description of what is fixed or changed

Don't catch AttributeError in diophantine and sympify the input equation.

Other comments

Release Notes

  • solvers
    • The diophantine solver no longer raises for unsympified inputs.

@sympy-bot
Copy link

sympy-bot commented Jan 2, 2020

Hi, I am the SymPy bot (v149). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • solvers

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed

Don't catch `AttributeError` in diophantine and sympify the input equation.

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* solvers
    * The diophantine solver no longer raises for unsympified inputs.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #18201 into master will increase coverage by 0.014%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##            master   #18201       +/-   ##
============================================
+ Coverage   74.936%   74.95%   +0.014%     
============================================
  Files          642      642               
  Lines       167128   167130        +2     
  Branches     39331    39331               
============================================
+ Hits        125240   125265       +25     
+ Misses       36351    36323       -28     
- Partials      5537     5542        +5

@jksuom jksuom merged commit 6be36ff into sympy:master Jan 2, 2020
@oscarbenjamin oscarbenjamin deleted the pr_attribute_diop branch January 9, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants