[feature] make Curve callable with parameter value

[namannimmo10]

References to other Issues or PRs

Closes #17997

Brief description of what is fixed or changed

Other comments

Release Notes

• geometry
  • Add __call__ method in Class Curve.

[sympy-bot]

✅

Hi, I am the SymPy bot (v149). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

• geometry
  • Add __call__ method in Class Curve. (#18250 by @namannimmo10)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->
Closes #17997

#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
*  geometry
    *  Add `__call__ `method in `Class Curve`.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

[namannimmo10]

Hi @smichr, Please review this PR!

[smichr]

It looks ok to me. Let's see if others have any feedback.

[codecov]

Codecov Report

Merging #18250 into master will increase coverage by 0.035%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##            master    #18250       +/-   ##
=============================================
+ Coverage   74.931%   74.966%   +0.035%     
=============================================
  Files          642       642               
  Lines       166973    167296      +323     
  Branches     39283     39370       +87     
=============================================
+ Hits        125115    125416      +301     
- Misses       36329     36344       +15     
- Partials      5529      5536        +7

[namannimmo10]

Does that look okay to you? @oscarbenjamin @asmeurer

[oscarbenjamin]

Does it matter that you can substitute points outside of the range?

In [6]: Curve((t, t**2), (t, 0, 10))                                                                                                           
Out[6]: Curve((t, t**2), (t, 0, 10))

In [7]: c.subs(t, 20)                                                                                                                          
Out[7]: Point2D(20, 400)

In [8]: c(20)                                                                                                                                  
Out[8]: Point2D(20, 400)

Maybe that's an unrelated point though. Adding __call__ seems fine to me.

[namannimmo10]

Does it matter that you can substitute points outside of the range?

I don't think that matters. Those are the limits and we can substitute points outside that range.

>>> a
Curve((t, t**2), (t, 0, 10))
>>> a(20)
Point2D(20, 400)
>>> a.limits
(t, 0, 10)

@smichr It's ready now. Please merge this.

[smichr]

Does it matter that you can substitute points outside of the range?

That was part of the rational for issue #18254 - with such a change then using parameter from 0 to 1 on the arbitrary point would recreate the curve.