Fixed test failure with cache off

[Smit-create]

Fixed test failure with cache off

References to other Issues or PRs

Fixes #18104

Brief description of what is fixed or changed

Other comments

Release Notes

• physics.vector
  • Fixed test failure for test_dyadic with cache off

[sympy-bot]

✅

Hi, I am the SymPy bot (v149). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

• physics.vector
  • Fixed test failure for test_dyadic with cache off (#18405 by @Smit-create)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->
Fixed test failure with cache off
#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Fixes #18104

#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* physics.vector
  * Fixed test failure for test_dyadic with cache off
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

[codecov]

Codecov Report

Merging #18405 into master will increase coverage by 0.017%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##            master   #18405       +/-   ##
============================================
+ Coverage   75.292%   75.31%   +0.017%     
============================================
  Files          633      633               
  Lines       166948   166948               
  Branches     39397    39397               
============================================
+ Hits        125700   125729       +29     
+ Misses       35713    35687       -26     
+ Partials      5535     5532        -3

[oscarbenjamin]

Have you identified the cause of the failure? I think it would be better to fix that than change the test.

Or at least a new issue should be opened showing the code that behaves differently depending on whether the cache is used.

[oscarbenjamin]

I think this can be merged if a new issue is opened showing how to reproduce the cache-dependent failure.

[Smit-create]

Yes Surely, I would look to find the failure and open an issue.

[Smit-create]

I have opened an issue #18423 related to this.

[Smit-create]

@oscarbenjamin Is this ready to merge now?

[oscarbenjamin]

Looks good