Fixes Typo in factortools and removes XFail for test_issue_5786

[iammosespaulr]

References to other Issues or PRs

Fixes #18895
Closes #19039

Brief description of what is fixed or changed

This was already fixed by @skirpichev in his fork sometime last year. I fixed it in sympy and removed an XFail test

Other comments

Release Notes

• polys
  • Fixed an issue when calling factor() with an extension

[sympy-bot]

✅

Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

• polys
  • Fixed an issue when calling factor() with an extension (#19040 by @iammosespaulr)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Fixes #18895
Closes #19039 
#### Brief description of what is fixed or changed
This was already fixed by [@skirpichev in his fork sometime last year](https://github.com/skirpichev/diofant/commit/ffc0ba1c726a2e4fe586449084cc03475fe442e1). I fixed it in sympy and removed an XFail test

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* polys
  * Fixed an issue when calling factor() with an extension
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

[iammosespaulr]

@oscarbenjamin I think this ought to do for #18895 . wdys?

[asmeurer]

Looks good to me.

[oscarbenjamin]

Is this copied from diofant?

[iammosespaulr]

Is this copied from diofant?

Not copied ... it's a typo from sympy, which was fixed in diofant way earlier ... I haven't copied anything other than a single Letter 😄

[asmeurer]

Yeah, it looks like a distinct change to me.

[oscarbenjamin]

Okay good. It's important to be clear.

[codecov]

Codecov Report

Merging #19040 into master will increase coverage by 0.004%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master    #19040       +/-   ##
=============================================
+ Coverage   75.758%   75.763%   +0.004%     
=============================================
  Files          648       648               
  Lines       168805    168805               
  Branches     39791     39791               
=============================================
+ Hits        127884    127892        +8     
+ Misses       35355     35349        -6     
+ Partials      5566      5564        -2     

[iammosespaulr]

@oscarbenjamin @asmeurer The checks've passed!

[oscarbenjamin]

It seems that this was not a typo and was changed back in #19376