Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 2 rules in mathematica parser #19135

Merged
merged 6 commits into from
Apr 18, 2020
Merged

add 2 rules in mathematica parser #19135

merged 6 commits into from
Apr 18, 2020

Conversation

asukaminato0721
Copy link
Contributor

@asukaminato0721 asukaminato0721 commented Apr 16, 2020

References to other Issues or PRs

Brief description of what is fixed or changed

add two rules

ArcTan[x,y] -> atan2(y,x)
Pochhammer[x,y] -> rf(x,y)

Other comments

Release Notes

  • parsing
    • Added 2 new rules for mathematica parser.

wuyudi added 2 commits April 16, 2020 14:16
Add this rule:  'Pochhammer[x,y]':'rf(x,y)'
add 'ArcTan[x,y]':'atan2(y,x)'
@sympy-bot
Copy link

sympy-bot commented Apr 16, 2020

Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • parsing

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed

add two rules

```
ArcTan[x,y] -> atan2(y,x)
Pochhammer[x,y] -> rf(x,y)
```

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* parsing
  * Added 2 new rules for mathematica parser.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #19135 into master will decrease coverage by 0.011%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##            master    #19135       +/-   ##
=============================================
- Coverage   75.762%   75.751%   -0.012%     
=============================================
  Files          650       650               
  Lines       169039    169203      +164     
  Branches     39861     39919       +58     
=============================================
+ Hits        128069    128174      +105     
- Misses       35378     35457       +79     
+ Partials      5592      5572       -20     

@sylee957
Copy link
Member

Can you add some tests in test_mathematica.py?

Add test for mathematica paser.

if __name__ == "__main__":
testlist = [
'Sqrt[x]',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this whole __main__ block from here. Include tests within test_mathematica.py of parsing/tests.

wuyudi added 3 commits April 18, 2020 02:52
delete __name__=="__main__"  ,instead, put it in test_mathematica.py
Add 'ArcTan[x,y]': 'atan2(y,x)' and  'Pochhammer[x,y]': 'rf(x,y)'.
@sylee957 sylee957 merged commit 8aef2db into sympy:master Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants