-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 2 rules in mathematica parser #19135
Conversation
Add this rule: 'Pochhammer[x,y]':'rf(x,y)'
✅ Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like: This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
Codecov Report
@@ Coverage Diff @@
## master #19135 +/- ##
=============================================
- Coverage 75.762% 75.751% -0.012%
=============================================
Files 650 650
Lines 169039 169203 +164
Branches 39861 39919 +58
=============================================
+ Hits 128069 128174 +105
- Misses 35378 35457 +79
+ Partials 5592 5572 -20 |
Can you add some tests in test_mathematica.py? |
sympy/parsing/mathematica.py
Outdated
|
||
if __name__ == "__main__": | ||
testlist = [ | ||
'Sqrt[x]', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this whole __main__
block from here. Include tests within test_mathematica.py
of parsing/tests.
delete __name__==__main__
delete __name__=="__main__" ,instead, put it in test_mathematica.py
Add 'ArcTan[x,y]': 'atan2(y,x)' and 'Pochhammer[x,y]': 'rf(x,y)'.
References to other Issues or PRs
Brief description of what is fixed or changed
add two rules
Other comments
Release Notes