Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symbolic spline #19272

Merged
merged 1 commit into from May 10, 2020
Merged

symbolic spline #19272

merged 1 commit into from May 10, 2020

Conversation

smichr
Copy link
Member

@smichr smichr commented May 8, 2020

References to other Issues or PRs

fixes #19262

Brief description of what is fixed or changed

Other comments

Release Notes

  • functions
    • bsplines are more robust in terms of handling symbolic knots

@sympy-bot
Copy link

sympy-bot commented May 8, 2020

Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • functions
    • bsplines are more robust in terms of handling symbolic knots (#19272 by @smichr)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->

fixes #19262

#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* functions
    * bsplines are more robust in terms of handling symbolic knots
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #19272 into master will decrease coverage by 0.039%.
The diff coverage is 80.000%.

@@              Coverage Diff              @@
##            master    #19272       +/-   ##
=============================================
- Coverage   75.649%   75.610%   -0.040%     
=============================================
  Files          651       651               
  Lines       169487    169478        -9     
  Branches     40021     40016        -5     
=============================================
- Hits        128216    128143       -73     
- Misses       35654     35726       +72     
+ Partials      5617      5609        -8     

@jksuom
Copy link
Member

jksuom commented May 8, 2020

How about using a dummy with no assumptions when constructing the spline polynomials and replacing that with x only in the output?

@smichr smichr merged commit bea2902 into sympy:master May 10, 2020
@smichr smichr deleted the bspline branch May 10, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bspline error with symbolic knots
3 participants