Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plot for 1.6 #19284

Merged
merged 2 commits into from
May 10, 2020
Merged

Fix plot for 1.6 #19284

merged 2 commits into from
May 10, 2020

Conversation

sylee957
Copy link
Member

References to other Issues or PRs

Brief description of what is fixed or changed

#19252 for 1.6 branch

Other comments

Release Notes

  • plotting
    • Fixed plot3d_parametric_line plotting curves out of the box.

@sympy-bot
Copy link

sympy-bot commented May 10, 2020

Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • plotting
    • Fixed plot3d_parametric_line plotting curves out of the box. (#19284 by @sylee957)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed

#19252 for 1.6 branch

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
- plotting
  - Fixed plot3d_parametric_line plotting curves out of the box.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@oscarbenjamin
Copy link
Contributor

Thanks @sylee957 for the quick work on this

@codecov
Copy link

codecov bot commented May 10, 2020

Codecov Report

Merging #19284 into 1.6 will decrease coverage by 0.029%.
The diff coverage is 23.711%.

@@              Coverage Diff              @@
##               1.6    #19284       +/-   ##
=============================================
- Coverage   75.678%   75.648%   -0.030%     
=============================================
  Files          651       651               
  Lines       169489    169528       +39     
  Branches     40021     40021               
=============================================
- Hits        128266    128246       -20     
- Misses       35612     35664       +52     
- Partials      5611      5618        +7     

@oscarbenjamin
Copy link
Contributor

Thanks

@oscarbenjamin oscarbenjamin merged commit eddf8b8 into sympy:1.6 May 10, 2020
@sylee957 sylee957 deleted the fix_plot_1.6 branch May 10, 2020 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants