New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong computations of Fourier series #19382
Conversation
✅ Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
Codecov Report
@@ Coverage Diff @@
## master #19382 +/- ##
=============================================
+ Coverage 75.618% 75.766% +0.147%
=============================================
Files 651 652 +1
Lines 169418 170795 +1377
Branches 39973 40322 +349
=============================================
+ Hits 128112 129406 +1294
- Misses 35703 35774 +71
- Partials 5603 5615 +12 |
Looks good |
Thanks! This will help a lot if I start teaching Fourier series with sympy in SageMath, CoCalc or Jupyter. |
References to other Issues or PRs
Fixes #19375
Fixes #19044
Brief description of what is fixed or changed
If the center of the integration limits are not origin, detecting whether the function is even or not is more complicated, and it may not even be worth testing it out because substituting
x
to some shifted values ofx
can have the issues of equality.Other comments
I've also made the docs clear about the definitions because it was unclear how limits is supposed to do, and made some plotting examples for it.
Release Notes
fourier_series
for even or odd functions withlimits
that are specified non-central.