Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cot.as_real_imag #19468

Merged
merged 1 commit into from Jun 3, 2020
Merged

Conversation

gschintgen
Copy link
Contributor

References to other Issues or PRs

Fixes #19366

Brief description of what is fixed or changed

Sign error in the formula.

Other comments

The patch has kindly been provided by the reporter. (See #19366 for a proof of its validity.)

Release Notes

  • functions
    • Fixed cot.as_real_imag (sign error in imaginary part)

@sympy-bot
Copy link

sympy-bot commented May 31, 2020

Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

#### References to other Issues or PRs
Fixes #19366 

#### Brief description of what is fixed or changed
Sign error in the formula.

#### Other comments
The patch has kindly been provided by the reporter. (See #19366 for a proof of its validity.)

#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* functions
  * Fixed `cot.as_real_imag` (sign error in imaginary part)
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@codecov
Copy link

codecov bot commented May 31, 2020

Codecov Report

Merging #19468 into master will increase coverage by 0.019%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master    #19468       +/-   ##
=============================================
+ Coverage   75.638%   75.658%   +0.019%     
=============================================
  Files          652       652               
  Lines       169756    169756               
  Branches     40072     40072               
=============================================
+ Hits        128401    128434       +33     
+ Misses       35742     35711       -31     
+ Partials      5613      5611        -2     

@oscarbenjamin
Copy link
Contributor

Looks good. Thanks!

@oscarbenjamin oscarbenjamin merged commit 929f55b into sympy:master Jun 3, 2020
@gschintgen gschintgen deleted the fix-19366-cot-real-imag branch June 6, 2020 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sign error in as_real_imag method of cotangent
5 participants