Fix double printing in the string and latex printers #19614
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs
This is some preliminary cleanup to prepare for gh-19611
Brief description of what is fixed or changed
LatexPrinter
now avoids callingself._print(self._print(x))
in all places reached by the test.This means that subclasses are free to define
_print_str
to put quotes around the string, without breaking printing of builtin objects.It also means printing will be marginally faster.
Other comments
Release Notes
LatexPrinter._print
is no longer called on strings which have already been converted to Latex.