Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use literal suffix print pow #19956

Merged
merged 3 commits into from Aug 13, 2020
Merged

Conversation

bjodah
Copy link
Member

@bjodah bjodah commented Aug 12, 2020

References to other Issues or PRs

This PR merges changes from master into gh-19710 and also adds a test to guard against future regressions (fixes gh-19710).

Brief description of what is fixed or changed

This PR supersedes gh-19710 (it just adds a merge commit and a commit adding a test).

Other comments

cc @mmohrhard

Release Notes

  • printing
    • Use literal suffix for 1.0 in C89CodePrinter's printing of pow when the exponent is -1

@sympy-bot
Copy link

sympy-bot commented Aug 12, 2020

Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • printing
    • Use literal suffix for 1.0 in C89CodePrinter's printing of pow when the exponent is -1 (#19956 by @bjodah and @mmohrhard)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
This PR merges changes from master into gh-19710 and also adds a test to guard against future regressions (fixes gh-19710).
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed
This PR supersedes gh-19710 (it just adds a merge commit and a commit adding a test).

#### Other comments
cc @mmohrhard 

#### Release Notes
<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* printing
  * Use literal suffix for 1.0 in C89CodePrinter's printing of pow when the exponent is -1
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #19956 into master will decrease coverage by 0.009%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master    #19956       +/-   ##
=============================================
- Coverage   75.788%   75.778%   -0.010%     
=============================================
  Files          668       668               
  Lines       173201    173202        +1     
  Branches     40844     40844               
=============================================
- Hits        131266    131250       -16     
- Misses       36220     36235       +15     
- Partials      5715      5717        +2     

@bjodah bjodah merged commit 8f6bc59 into sympy:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants