New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve kwarg-handling of print helper functions #20067
Conversation
✅ Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
This reverts two regressions in `latex` introduced in sympygh-15080, namely that: * `latex` started accepted positional arguments for settings * `latex` no longer respects the global printer defaults This also makes the signature more useful on `sstr`, `srepr`, `sstrrepr`, `pretty`, and `mathml`.
c0ea271
to
f1277b0
Compare
Codecov Report
@@ Coverage Diff @@
## master #20067 +/- ##
=============================================
- Coverage 75.854% 75.847% -0.007%
=============================================
Files 670 670
Lines 173703 173720 +17
Branches 40980 40980
=============================================
+ Hits 131762 131763 +1
- Misses 36202 36220 +18
+ Partials 5739 5737 -2 |
Looks good! |
This reverts two regressions in
latex
introduced in gh-15080, namely that:latex
started accepted positional arguments for settingslatex
stopped respecting the global printer defaultsThis also makes the signature more useful on
sstr
,srepr
,sstrrepr
,pretty
, andmathml
.References to other Issues or PRs
#15080
Brief description of what is fixed or changed
See the test
Other comments
Release Notes
latex
now once again requires settings to be passed as keyword and not positional arguments, and respects printer settings changed withset_global_settings
; restoring the behavior from sympy 1.2 and earlier.