Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve kwarg-handling of print helper functions #20067

Merged
merged 1 commit into from Sep 15, 2020

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Sep 10, 2020

This reverts two regressions in latex introduced in gh-15080, namely that:

  • latex started accepted positional arguments for settings
  • latex stopped respecting the global printer defaults

This also makes the signature more useful on sstr, srepr, sstrrepr, pretty, and mathml.

References to other Issues or PRs

#15080

Brief description of what is fixed or changed

See the test

Other comments

Release Notes

  • printing
    • latex now once again requires settings to be passed as keyword and not positional arguments, and respects printer settings changed with set_global_settings; restoring the behavior from sympy 1.2 and earlier.

@sympy-bot
Copy link

sympy-bot commented Sep 10, 2020

Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • printing
    • latex now once again requires settings to be passed as keyword and not positional arguments, and respects printer settings changed with set_global_settings; restoring the behavior from sympy 1.2 and earlier. (#20067 by @eric-wieser)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

This reverts two regressions in `latex` introduced in gh-15080, namely that:

* `latex` started accepted positional arguments for settings
* `latex` stopped respecting the global printer defaults

This also makes the signature more useful on `sstr`, `srepr`, `sstrrepr`, `pretty`, and `mathml`.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
#15080


#### Brief description of what is fixed or changed
See the test


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* printing
  * `latex` now once again requires settings to be passed as keyword and not positional arguments, and respects printer settings changed with `set_global_settings`; restoring the behavior from sympy 1.2 and earlier.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

This reverts two regressions in `latex` introduced in sympygh-15080, namely that:

* `latex` started accepted positional arguments for settings
* `latex` no longer respects the global printer defaults

This also makes the signature more useful on `sstr`, `srepr`, `sstrrepr`, `pretty`, and `mathml`.
@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #20067 into master will decrease coverage by 0.006%.
The diff coverage is 95.000%.

@@              Coverage Diff              @@
##            master    #20067       +/-   ##
=============================================
- Coverage   75.854%   75.847%   -0.007%     
=============================================
  Files          670       670               
  Lines       173703    173720       +17     
  Branches     40980     40980               
=============================================
+ Hits        131762    131763        +1     
- Misses       36202     36220       +18     
+ Partials      5739      5737        -2     

@oscarbenjamin
Copy link
Contributor

Looks good!

@oscarbenjamin oscarbenjamin merged commit edb676f into sympy:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants