Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sympify_return in Boolean in the same way as Expr #20093

Merged
merged 1 commit into from Sep 16, 2020

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Sep 16, 2020

With this in place, nonsense like x ^ "false" is now an error rather than incurring the string parser.

I've removed the docstrings because they're "obvious", and python provides an inherited docstring anyway.

References to other Issues or PRs

Brief description of what is fixed or changed

Other comments

Release Notes

  • logic
    • Binary boolean operators on Boolean objects no longer coerce strings

@sympy-bot
Copy link

sympy-bot commented Sep 16, 2020

Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • logic
    • Binary boolean operators on Boolean objects no longer coerce strings (#20093 by @eric-wieser)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

With this in place, nonsense like `x ^ "false"` is now an error rather than incurring the string parser.

I've removed the docstrings because they're "obvious", and python provides an inherited docstring anyway.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* logic
  * Binary boolean operators on `Boolean` objects no longer coerce strings
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

With this in place, nonsense like `x ^ "false"` is now an error rather than incurring the string parser
@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #20093 into master will decrease coverage by 0.018%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master    #20093       +/-   ##
=============================================
- Coverage   75.854%   75.836%   -0.019%     
=============================================
  Files          670       671        +1     
  Lines       173557    173624       +67     
  Branches     40979     40998       +19     
=============================================
+ Hits        131651    131670       +19     
- Misses       36169     36210       +41     
- Partials      5737      5744        +7     

@oscarbenjamin
Copy link
Contributor

Looks to be another case were tests are complete on Travis but the PR isn't updated to be mergeable (#19589).

@oscarbenjamin
Copy link
Contributor

It seems that last comment prompted github to update the status.

This looks good.

@oscarbenjamin oscarbenjamin merged commit 00ac28a into sympy:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants