Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zero raised to power -infinity gives zoo #20212

Merged
merged 2 commits into from Oct 7, 2020
Merged

zero raised to power -infinity gives zoo #20212

merged 2 commits into from Oct 7, 2020

Conversation

sidhu1012
Copy link
Contributor

References to other Issues or PRs

Fixes #19572

Brief description of what is fixed or changed

Earlier 0 ** -oo gave 0 instead of zoo

Other comments

Release Notes

  • core
    • Zero raised to power Negative Infinity gives ComplexInfinity(zoo) instead of zero

@sympy-bot
Copy link

sympy-bot commented Oct 6, 2020

Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • core
    • Zero raised to power Negative Infinity gives ComplexInfinity(zoo) instead of zero (#20212 by @sidhu1012)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Fixes #19572

#### Brief description of what is fixed or changed
Earlier  0 ** -oo gave 0 instead of zoo

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
- core
     - Zero raised to power Negative Infinity gives ComplexInfinity(zoo) instead of zero
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #20212 into master will increase coverage by 11.321%.
The diff coverage is 100.000%.

@@              Coverage Diff               @@
##            master    #20212        +/-   ##
==============================================
+ Coverage   64.385%   75.706%   +11.321%     
==============================================
  Files          671       671                
  Lines       174144    174146         +2     
  Branches     41093     41094         +1     
==============================================
+ Hits        112123    131840     +19717     
+ Misses       55599     36551     -19048     
+ Partials      6422      5755       -667     

@sidhu1012
Copy link
Contributor Author

Review pls


def test_issue_19572():
assert 0 ** -oo is zoo
assert power(0, -oo) is zoo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to test_zero above rather than a new test function? You can include the url for the issue in a comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sure

@sidhu1012
Copy link
Contributor Author

sidhu1012 commented Oct 6, 2020

@oscarbenjamin Transferred the test cases to test_zero()

@sidhu1012
Copy link
Contributor Author

Is it good to go ?

@oscarbenjamin
Copy link
Contributor

Yes, looks good

@oscarbenjamin oscarbenjamin merged commit 3556dbf into sympy:master Oct 7, 2020
@sidhu1012 sidhu1012 deleted the zoo branch October 7, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0**-oo produces 0, the documentation says it should produce zoo
3 participants