Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed is_integer of Mul by not using fraction but collecting numerators and denominators directly (1.7) #20450

Merged
merged 8 commits into from Nov 19, 2020
Merged

fixed is_integer of Mul by not using fraction but collecting numerators and denominators directly (1.7) #20450

merged 8 commits into from Nov 19, 2020

Conversation

tbennun
Copy link

@tbennun tbennun commented Nov 18, 2020

References to other Issues or PRs

Fixes #20161

Brief description of what is fixed or changed

In Mul._eval_is_integer instead of using the function fraction the args are scanned for contributions to the numerator and denominator.

Other comments

This is a cherry-pick of #20322 pointed towards the 1.7 branch.

Release Notes

  • core
    • Fixed a few broken cases of expr.is_integer

@sympy-bot
Copy link

sympy-bot commented Nov 18, 2020

Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
Fixes #20161

#### Brief description of what is fixed or changed
In Mul._eval_is_integer instead of using the function fraction the args are scanned for contributions to the numerator and denominator.


#### Other comments

This is a cherry-pick of #20322 pointed towards the `1.7` branch.

#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* core
  * Fixed a few broken cases of expr.is_integer
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@oscarbenjamin oscarbenjamin added this to the SymPy 1.7 milestone Nov 18, 2020
@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #20450 (73f3d75) into 1.7 (9e7ae94) will increase coverage by 0.000%.
The diff coverage is 100.000%.

@@            Coverage Diff            @@
##               1.7    #20450   +/-   ##
=========================================
  Coverage   75.703%   75.704%           
=========================================
  Files          674       674           
  Lines       174162    174175   +13     
  Branches     41098     41103    +5     
=========================================
+ Hits        131847    131858   +11     
- Misses       36565     36569    +4     
+ Partials      5750      5748    -2     

@oscarbenjamin
Copy link
Contributor

Thanks. This looks good!

@oscarbenjamin oscarbenjamin merged commit 7d94205 into sympy:1.7 Nov 19, 2020
@tbennun tbennun deleted the coproc-fix-20161_Mul-is_integer-directly branch November 20, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants