New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed is_integer of Mul by not using fraction but collecting numerators and denominators directly (1.7) #20450
fixed is_integer of Mul by not using fraction but collecting numerators and denominators directly (1.7) #20450
Conversation
…ors and denominators directoly (cherry picked from commit 73dc653)
(cherry picked from commit 481d063)
(cherry picked from commit 23490db)
(cherry picked from commit 478dd3f)
(cherry picked from commit a7af998)
(cherry picked from commit 425125e)
…; also handle the case 0**0 (cherry picked from commit f0c9423)
(cherry picked from commit de4cc96)
✅ Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like: This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
Codecov Report
@@ Coverage Diff @@
## 1.7 #20450 +/- ##
=========================================
Coverage 75.703% 75.704%
=========================================
Files 674 674
Lines 174162 174175 +13
Branches 41098 41103 +5
=========================================
+ Hits 131847 131858 +11
- Misses 36565 36569 +4
+ Partials 5750 5748 -2 |
Thanks. This looks good! |
References to other Issues or PRs
Fixes #20161
Brief description of what is fixed or changed
In Mul._eval_is_integer instead of using the function fraction the args are scanned for contributions to the numerator and denominator.
Other comments
This is a cherry-pick of #20322 pointed towards the
1.7
branch.Release Notes