New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected paramateric_region_list and the tests using the method #20867
Conversation
✅ Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.8. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
Thanks for making this PR @almighty123789. This looks good to me. Just improve the release notes. |
@friyaz thanks for commenting and reviwing the PR. Can you tell me what more should I add to the release notes ? Thanks. |
How about "Fixed a bug with integral over |
Thanks, I do not have merging rights yet. @oscarbenjamin Can you merge this please if it looks good to you? |
@friyaz I have given you push access. Please read https://github.com/sympy/sympy/wiki/Pushing-patches. |
Thanks, @asmeurer for this! |
References to other Issues or PRs
Fixes #20748
Brief description of what is fixed or changed
The paramteric_region_method was earlier substituting
tan (t)
rather thattan(t/2)
, when parametrizing ImplicitRegion object to ParametricRegion objects. This resulted in the value of final computed answer becoming twice of what it should have been, as can be seen from the OP.Other comments
The earlier tests had wrong answers, this pr fixes them also.
Release Notes