Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected paramateric_region_list and the tests using the method #20867

Merged
merged 2 commits into from Feb 18, 2021
Merged

Corrected paramateric_region_list and the tests using the method #20867

merged 2 commits into from Feb 18, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 27, 2021

References to other Issues or PRs

Fixes #20748

Brief description of what is fixed or changed

The paramteric_region_method was earlier substituting tan (t) rather that tan(t/2) , when parametrizing ImplicitRegion object to ParametricRegion objects. This resulted in the value of final computed answer becoming twice of what it should have been, as can be seen from the OP.

Other comments

The earlier tests had wrong answers, this pr fixes them also.

Release Notes

  • vector
    • Fixed a bug with integral over ImplicitRegion objects

@sympy-bot
Copy link

sympy-bot commented Jan 27, 2021

Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.8.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Fixes #20748 


#### Brief description of what is fixed or changed
The paramteric_region_method  was earlier substituting `tan (t)` rather that `tan(t/2)`  , when parametrizing ImplicitRegion object to ParametricRegion objects. This resulted in the value of final computed answer becoming twice of what it should have been, as can be seen from the OP.

#### Other comments
The earlier tests had wrong answers, this pr fixes them also.

#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
- vector 
  - Fixed a bug with integral over ImplicitRegion objects
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@friyaz friyaz added the vector label Jan 28, 2021
@friyaz
Copy link
Member

friyaz commented Jan 28, 2021

Thanks for making this PR @almighty123789. This looks good to me. Just improve the release notes.

@ghost
Copy link
Author

ghost commented Jan 28, 2021

@friyaz thanks for commenting and reviwing the PR. Can you tell me what more should I add to the release notes ? Thanks.

@friyaz
Copy link
Member

friyaz commented Jan 28, 2021

How about "Fixed a bug with integral over ImplicitRegion objects?

@friyaz
Copy link
Member

friyaz commented Jan 28, 2021

Thanks, I do not have merging rights yet. @oscarbenjamin Can you merge this please if it looks good to you?

@asmeurer
Copy link
Member

@friyaz I have given you push access. Please read https://github.com/sympy/sympy/wiki/Pushing-patches.

@friyaz
Copy link
Member

friyaz commented Feb 18, 2021

Thanks, @asmeurer for this!

@friyaz friyaz merged commit a745072 into sympy:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sympy.vector Implicit_Region result wrong for perimeter of unit circle version 1.7.1
4 participants