Fixed a bug in primetest.py -> is_gaussian_prime #20912
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Changed the invocation of
as_int
function to use the flagstrict=False
in the functionis_gaussian_prime
ofsympy.ntheory
module in order to fix the following bug.The bug:
Using the standard python "complex" library to do
sympy.ntheory.is_gaussian_prime(1+1j)
results in
ValueError
which is caused due to the usage of the defaultstrict=True
flag while invoking theas_int
function.Resolution:
Override the default
strict=True
flag to usestrict=False
while invoking theas_int
function.is_gaussian_prime
function for python complex numbers (e.g.1+1j
).