Implemented function returning Wilkinson Matrix #20922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like: This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.8. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
|
@sylee957, please review |
sylee957
reviewed
Feb 8, 2021
sympy/matrices/common.py
Outdated
| @@ -1208,6 +1208,51 @@ def entry(i, j): | |||
| return kls.zero | |||
| return kls._new(size, size, entry) | |||
|
|
|||
| @classmethod | |||
| def Wilkinson(kls, n): | |||
There was a problem hiding this comment.
Suggested change
| def Wilkinson(kls, n): | |
| def wilkinson(kls, n): |
I'd try to use lowercase for method names
sylee957
reviewed
Feb 8, 2021
sympy/matrices/common.py
Outdated
| wminus = diag([i for i in range(-n, n + 1)], unpack=True) + D + D.T | ||
| wplus = abs(diag([i for i in range(-n, n + 1)], unpack=True)) + D + D.T | ||
|
|
||
| return wminus, wplus |
There was a problem hiding this comment.
As I'd noted in #20911, you should consider the class of the output to match the class of the method it's invoked from
So you should check the returns are in the following classes
MutableDenseMatrix.wilkinson -> MutableDenseMatrix
MutableSparseMatrix.wilkinson -> MutableSparseMatrix
ImmutableDenseMatrix.wilkinson -> ImmutableDenseMatrix
ImmutableSparseMatrix.wilkinson -> ImmutableSparseMatrix
There was a problem hiding this comment.
I've fixed this in latest commit.
>>> from sympy import MutableSparseMatrix, ImmutableDenseMatrix, ImmutableSparseMatrix, MutableDenseMatrix
>>> w_m, w_p = MutableDenseMatrix.wilkinson(1)
>>> type(w_m)
<class 'sympy.matrices.dense.MutableDenseMatrix'>
>>> w_m, w_p = MutableSparseMatrix.wilkinson(1)
>>> type(w_m)
<class 'sympy.matrices.sparse.MutableSparseMatrix'>
>>> w_m, w_p = ImmutableDenseMatrix.wilkinson(1)
>>> type(w_m)
<class 'sympy.matrices.immutable.ImmutableDenseMatrix'>
>>> w_m, w_p = ImmutableSparseMatrix.wilkinson(1)
>>> type(w_m)
<class 'sympy.matrices.immutable.ImmutableSparseMatrix'>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of what is fixed or changed
Implemented function returning Wilkinson matrix
Release Notes