RecursionError in integrate fixed

[nisargsc]

References to other Issues or PRs

Partial fix for #21034

Brief description of what is fixed or changed

Applies the diff mentions by @oscarbenjamin here. This fixes one of the problems in the issue, i.e. RecurstionError caused due to not x.is_extended_real in sympy/core/expr.py

Release Notes

• core
  • Fixed a bug in Expr.round that could lead to infinite recursion in integrate.

[sympy-bot]

✅

Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

• core
  • Fixed a bug in Expr.round that could lead to infinite recursion in integrate. (#21053 by @Nisarg-Chaudhari)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.8.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Partial fix for #21034 

#### Brief description of what is fixed or changed
Applies the diff mentions by @oscarbenjamin [here](https://github.com/sympy/sympy/issues/21034#issuecomment-790178650). This fixes one of the problems in the issue, i.e. `RecurstionError` caused due to `not x.is_extended_real` in `sympy/core/expr.py`

#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* core
  * Fixed a bug in `Expr.round` that could lead to infinite recursion in `integrate`.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

[oscarbenjamin]

Looking at this again there's really just one bug here which is this:

expr = -I*log((re(asin(5)) + I*im(asin(5)))/sqrt(re(asin(5))**2 + im(asin(5))**2))/pi
expr.round() # hangs

We can just add a test for that here in this file. The integral test should go in sympy.integrals somewhere.

[nisargsc]

on it.
also in sympy.integrals I'm adding it to sympy/interals/test_integrals.py is it fine?

[oscarbenjamin]

Does this also fix the other integral from the issue?

[nisargsc]

No, the other one still gives RecursionError: maximum recursion depth exceeded.

[oscarbenjamin]

Okay, since it doesn't fully fix the issue I've changed the OP to say "partial fix". If the OP says "fixes #12345" then when it is merged the issue will be closed but we don't want to close the issue unless it is fully fixed.

I've also edited the release not to make it clear that this was a bug in Expr.round.

This looks good so I'll merge it now. Thanks!