Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(polys): canonicalise gcd over ZZ_I #21353

Merged
merged 1 commit into from Apr 20, 2021
Merged

Conversation

oscarbenjamin
Copy link
Contributor

References to other Issues or PRs

Fixes #21342

Brief description of what is fixed or changed

The gcd computed over ZZ_I is now canonicalised wrt units so e.g.:

In [1]: gcd(-sqrt(-2), sqrt(-2))
Out[1]: √2

Previously this would give √2⋅ⅈ.

Other comments

Release Notes

  • polys
    • gcd over the Gaussian integers (ZZ_I) is now canonicalised with respect to multiplication by I.

@sympy-bot
Copy link

sympy-bot commented Apr 19, 2021

Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • polys
    • gcd over the Gaussian integers (ZZ_I) is now canonicalised with respect to multiplication by I. (#21353 by @oscarbenjamin)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.9.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->

Fixes #21342

#### Brief description of what is fixed or changed

The gcd computed over `ZZ_I` is now canonicalised wrt units so e.g.:
```python
In [1]: gcd(-sqrt(-2), sqrt(-2))
Out[1]: √2
```
Previously this would give `√2⋅ⅈ`. 

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* polys
    * gcd over the Gaussian integers (`ZZ_I`) is now canonicalised with respect to multiplication by `I`.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@jksuom
Copy link
Member

jksuom commented Apr 20, 2021

Looks good. Thanks!

@jksuom jksuom merged commit 6300c9f into sympy:master Apr 20, 2021
@oscarbenjamin oscarbenjamin deleted the pr_gcd_zz_i branch August 16, 2021 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1/(exp(it) - 2) integrates wrong
3 participants