Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure finite order before expanding bessel functions #21487

Merged
merged 1 commit into from
May 19, 2021

Conversation

ehren
Copy link
Contributor

@ehren ehren commented May 18, 2021

References to other Issues or PRs

Fixes #21486

Brief description of what is fixed or changed

Use is_positive/negative (which now implies finite) to guard against infinite recursion in bessel expand_func with e.g. besselj(oo, x)

Other comments

Release Notes

NO ENTRY

@ehren ehren force-pushed the bessel-expand-ensure-finite-order branch from 5befb1d to 5bc37ca Compare May 18, 2021 19:34
@sympy-bot
Copy link

Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.
Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->

Fixes #21486 

#### Brief description of what is fixed or changed

Use is_positive/negative (which now implies finite) to guard against infinite recursion in bessel `expand_func` with e.g. `besselj(oo, x)`

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->

NO ENTRY

<!-- END RELEASE NOTES -->

@ehren
Copy link
Contributor Author

ehren commented May 18, 2021

Might as well change the nearby is_extended_real guard to is_real as well (done in forcepush).

@oscarbenjamin
Copy link
Contributor

I guess this should have some sort of limit for finite cases as well e.g. expand_func(besselj(10000, x))

@smichr
Copy link
Member

smichr commented May 19, 2021

I guess this should have some sort of limit for finite cases as well

This is probably another issue; there aren't such limits for expansion of trig function, however. What has been presented here is an obvious case needing to not expand (forever) so let's commit this as is.

@smichr smichr merged commit 85dc4f3 into sympy:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expand_func(besselj(oo, x)) -> RecursionError
4 participants