Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor dep-div-indep hint #21588

Merged
merged 11 commits into from Jun 12, 2021
Merged

refactor dep-div-indep hint #21588

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
23a4521
refactor dep-div-indep hint
Mohitbalwani26 Jun 8, 2021
7ddf5de
refactor indep-div-dep
Mohitbalwani26 Jun 8, 2021
e6c7a2e
refactor homogenous coeff best
Mohitbalwani26 Jun 8, 2021
64bab8c
fix simplification result
Mohitbalwani26 Jun 8, 2021
1f0efcc
refactor linear_coefficients
Mohitbalwani26 Jun 9, 2021
065b15b
fix import
Mohitbalwani26 Jun 9, 2021
a9f4a3f
change test for _linear_coeff_match
Mohitbalwani26 Jun 9, 2021
f8e3d8a
fix sphinx failure
Mohitbalwani26 Jun 9, 2021
d706189
fix reference through obj
Mohitbalwani26 Jun 10, 2021
59897a2
fix autoclass
Mohitbalwani26 Jun 10, 2021
e2867b0
add members to every class
Mohitbalwani26 Jun 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 6 additions & 4 deletions doc/src/modules/solvers/ode.rst
View file
Open in desktop
Expand Up @@ -81,15 +81,17 @@ factorable

1st_homogeneous_coeff_best
^^^^^^^^^^^^^^^^^^^^^^^^^^
.. autofunction:: sympy.solvers.ode.ode::ode_1st_homogeneous_coeff_best
.. autofunction:: sympy.solvers.ode.single::HomogeneousCoeffBest

1st_homogeneous_coeff_subs_dep_div_indep
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
.. autofunction:: sympy.solvers.ode.ode::ode_1st_homogeneous_coeff_subs_dep_div_indep
.. autoclass:: sympy.solvers.ode.single::HomogeneousCoeffSubsDepDivIndep
:members:

1st_homogeneous_coeff_subs_indep_div_dep
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
.. autofunction:: sympy.solvers.ode.ode::ode_1st_homogeneous_coeff_subs_indep_div_dep
.. autoclass:: sympy.solvers.ode.single::HomogeneousCoeffSubsIndepDivDep
:members:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do some autoclass blocks have members but others not?

Is it useful to show the members?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

official documentation says if we keep the :members: block then it will include docstrings of member functions also. but in previous class like Factorable, initially it was not there but someone made commit stating 'expanding documentation', so I thought it is the practice to be followed.


1st_linear
^^^^^^^^^^
Expand Down Expand Up @@ -152,7 +154,7 @@ almost_linear

linear_coefficients
^^^^^^^^^^^^^^^^^^^
.. autofunction:: sympy.solvers.ode.ode::ode_linear_coefficients
.. autofunction:: sympy.solvers.ode.single::LinearCoefficients
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be autoclass?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this should be autoclass. will rectify it


separable_reduced
^^^^^^^^^^^^^^^^^
Expand Down