Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Bug in nonlinsolve #21602

Merged
merged 2 commits into from Jun 11, 2021
Merged

Fix: Bug in nonlinsolve #21602

merged 2 commits into from Jun 11, 2021

Conversation

shashankks0987
Copy link
Contributor

References to other Issues or PRs

Fixes #21584

Brief description of what is fixed or changed

earlier, nonlinsolve([Eq(1, x + y), Eq(1, -x + y - 1), Eq(1, -x + y - 1)],x,y) raised an Attribute error
now, it returns a solution

Other comments

Release Notes

  • solvers
    • Fixed a bug in nonlinsolve

earlier, nonlinsolve([Eq(1, x + y), Eq(1, -x + y - 1), Eq(1, -x + y - 1)],x,y) raised an Attribute error
now, it returns a solution
@sympy-bot
Copy link

sympy-bot commented Jun 11, 2021

Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.9.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Fixes #21584

#### Brief description of what is fixed or changed
earlier, nonlinsolve([Eq(1, x + y), Eq(1, -x + y - 1), Eq(1, -x + y - 1)],x,y) raised an Attribute error
now, it returns a solution

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* solvers
  * Fixed a bug in nonlinsolve
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@smichr smichr enabled auto-merge June 11, 2021 17:30
@smichr
Copy link
Member

smichr commented Jun 11, 2021

you could be more specific in your changes: 'nonlinsolve recognizes Equalities that may already be true or false'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in nonlinsolve
3 participants