[GSoC] Kovacic Solver - Part 1 #21770
Conversation
|
✅ Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.9. Click here to see the pull request description that was parsed. |
🟠Hi, I am the SymPy bot (v161). I've noticed that some of your commits add or delete files. Since this is sometimes done unintentionally, I wanted to alert you about it. This is an experimental feature of SymPy Bot. If you have any feedback on it, please comment at sympy/sympy-bot#75. The following commits add new files:
If these files were added/deleted on purpose, you can ignore this message. |
|
|
||
| if a not in match or b not in match or c not in match: | ||
| raise ValueError("Invalid Second Order Linear Homogeneous Equation") | ||
| return match[a], match[b], match[c] |
There was a problem hiding this comment.
Shouldn't this check that the matches are rational functions?
| ric_sol = [sol.rhs for sol in solve_riccati(g(x), x, b0, b1, b2)] | ||
|
|
||
| C1 = symbols('C1') | ||
| return set(map(lambda sol: exp(Integral(sol.subs(C1, 0), x).doit()), ric_sol)) |
There was a problem hiding this comment.
This should use Dummy so it doesn't clash with symbols from other calls to dsolve
There was a problem hiding this comment.
Also don't use map/lambda like this. A comprehension is clearer:
return {exp(Integral(sol.subs(C1, 0), x).doit()) for sol in ric_sol}
There was a problem hiding this comment.
Do we have the same problem with Function('g') above? Will this code break if the ODE already has a function named g in it?
There was a problem hiding this comment.
If I read this correctly, it is assuming that C1 is the constant that comes from the recursive dsolve solution. Is this something that is always true? How do we know the constant is 0? Can this be expressed as an initial condition?
There was a problem hiding this comment.
If I read this correctly, it is assuming that
C1is the constant that comes from the recursive dsolve solution. Is this something that is always true? How do we know the constant is 0? Can this be expressed as an initial condition?
Sometimes the riccati solver returns a general solution. However, we only need one particular solution for the auxiliary riccati equation to find the general solution for the second order ODE. That's the reason I'm substituting it with 0. We could substitute it with anything finite, it wouldn't matter.
There was a problem hiding this comment.
If we only need a particular solution is there a way of calling the Ricatti solver that just tried to find the first particular solution as quickly as possible?
There was a problem hiding this comment.
Actually the code is supposed to only find particular solutions. However what happens sometimes is that some coefficients remain undetermined when the undetermined coefficients are solved for the auxiliary equation, and so a general solution may appear instead of a particular solution. In either case, the time to calculate the solution doesn't change and it doesn't involve any slow steps like calculating any integrals.
There was a problem hiding this comment.
Does it just return the first particular solution found or does it still run through finding all of them?
| sol1 = zsol[0].rhs | ||
| sol2 = sol1*Integral(exp(Integral(-b, x).doit())/sol1**2, x) | ||
| zsol.append(Eq(z, sol2)) | ||
| return constantsimp(Eq(z, C1*zsol[0].rhs + C2*zsol[1].rhs), [C1, C2]) |
There was a problem hiding this comment.
We shouldn't use constantsimp here. Also it would be better not to evaluated the integrals automatically or at least it should be possible to control that.
|
We should add a function for reduction of order: |
This PR adds the part 1 of 3 of the Kovacic algorithm, an algorithm for solving second order linear homogeneous ODEs.
References to other Issues or PRs
Brief description of what is fixed or changed
Other comments
Release Notes