Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with matching #22047

Merged
merged 2 commits into from Sep 8, 2021
Merged

Fixed issue with matching #22047

merged 2 commits into from Sep 8, 2021

Conversation

oscargus
Copy link
Contributor

@oscargus oscargus commented Sep 7, 2021

References to other Issues or PRs

Extracted a part of #17443 that doesn't have to wait for the rest of the code.
Solves parts of #17354 (the matching issue, not the original one).

Brief description of what is fixed or changed

match with some expressions now work without throwing an error.

Other comments

Yes, catching ValueError is bad, but that is what we have to live with for now.

Release Notes

  • core
    • match no longer throws are exception for certain relationals.

@sympy-bot
Copy link

sympy-bot commented Sep 7, 2021

Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.10.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->

Extracted a part of #17443 that doesn't have to wait for the rest of the code.
Solves parts of #17354 (the matching issue, not the original one).

#### Brief description of what is fixed or changed
`match` with some expressions now work without throwing an error.

#### Other comments
Yes, catching `ValueError` is bad, but that is what we have to live with for now.

#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* core
    * `match` no longer throws are exception for certain relationals.  
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@github-actions
Copy link

github-actions bot commented Sep 7, 2021

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

sympy/core/basic.py Outdated Show resolved Hide resolved
@smichr smichr merged commit 9c1ab73 into sympy:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants