Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precedence for Mod, fix unary minus printing (fixes gh-17737) #22080

Merged
merged 3 commits into from Sep 13, 2021

Conversation

bjodah
Copy link
Member

@bjodah bjodah commented Sep 12, 2021

References to other Issues or PRs

Fixes #17737

Brief description of what is fixed or changed

Other comments

This PR is an alternative to gh-22032 and gh-20507

Release Notes

  • utilities
    • Fixed issue with incorrect lamdifying behaviour of Mod when modules = [].

@sympy-bot
Copy link

sympy-bot commented Sep 12, 2021

Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • utilities
    • Fixed issue with incorrect lamdifying behaviour of Mod when modules = []. (#22080 by @bjodah)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.10.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
Fixes #17737
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed


#### Other comments
This PR is an alternative to gh-22032 and gh-20507

#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* utilities
  * Fixed issue with incorrect lamdifying behaviour of `Mod` when `modules = []`.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@bjodah bjodah force-pushed the fix-lambdify-pycode-precedence branch from 1573ba7 to 82faea5 Compare September 12, 2021 07:14
@github-actions
Copy link

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@oscargus
Copy link
Contributor

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mod function lambdify bug
4 participants