Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved and corrected LaTeX printing of Mod #22091

Merged
merged 2 commits into from Sep 13, 2021

Conversation

oscargus
Copy link
Contributor

References to other Issues or PRs

Brief description of what is fixed or changed

Earlier Mod(x, y + 1) was printed as
image

Now it is printed as
image

Also, the LaTeX used \bmod{7} which is incorrect. It should just be \bmod 7 as \bmod is not a command. (Probably a confusion with \pmod which is used like that.)

Other comments

Still an issue with unary -, where both -Mod(x, y) and Mod(-x, y) ends up with the same output.

Release Notes

  • printing
    • Improved and corrected LaTeX-printing of Mod.

@sympy-bot
Copy link

sympy-bot commented Sep 13, 2021

Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • printing

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.10.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed
Earlier `Mod(x, y + 1)` was printed as
![image](https://user-images.githubusercontent.com/8114497/133048450-177d27fe-8720-45e9-b9a6-c39831e4f412.png)

Now it is printed as
![image](https://user-images.githubusercontent.com/8114497/133048044-d0e232b3-a1b2-48ad-b7ac-8c840f9be838.png)

Also, the LaTeX used `\bmod{7}` which is incorrect. It should just be `\bmod 7` as `\bmod` is not a command. (Probably a confusion with `\pmod` which is used like that.)

#### Other comments
Still an issue with unary -, where both `-Mod(x, y)` and `Mod(-x, y)` ends up with the same output.

#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* printing
     * Improved and corrected LaTeX-printing of `Mod`. 
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@smichr
Copy link
Member

smichr commented Sep 13, 2021

+1

@oscarbenjamin oscarbenjamin merged commit 980b11c into sympy:master Sep 13, 2021
@oscarbenjamin
Copy link
Contributor

Thanks

@oscargus oscargus deleted the modlatexprinting branch September 13, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants