Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Demo PR] Apply black formatting to sympy/solvers #22434

Closed
wants to merge 8 commits into from
Closed

[Demo PR] Apply black formatting to sympy/solvers #22434

wants to merge 8 commits into from

Commits on Nov 6, 2021

  1. ci: add config for black+isort 

    As recommended for existing projects, string normalization is switched
off:
https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#strings

Other config options, such as line width, are explained here:
https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#configuration-format

A config for isort was added in to ensure that isort is applied
in agreement with black once/if isort is applied
    @redeboer
    redeboer committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    f0ad6ca View commit details
    Browse the repository at this point in the history

  2. ci: add black as pre-commit hook 

    Pre-commit allows for incremental changes and pins the version of
the tool that is applied. Install as folllows:

    python3 -m pip install pre-commit
    pre-commit install
    @redeboer
    redeboer committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    ea6e4eb View commit details
    Browse the repository at this point in the history

  3. style: apply black formatting to sympy/solvers 

    See #17287 (comment)

Applied formatting as follows:

    # python3 -m pip install black==21.10b0
    black sympy/solvers
    @redeboer
    redeboer committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    66528eb View commit details
    Browse the repository at this point in the history

  4. ci: activate black string normalization

    @redeboer
    redeboer committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    ff2c81c View commit details
    Browse the repository at this point in the history

  5. style: apply black formatting to sympy/solvers 

    See #17287 (comment)

Applied formatting as follows:

    # python3 -m pip install black==21.10b0
    black sympy/solvers
    @redeboer
    redeboer committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    196c7eb View commit details
    Browse the repository at this point in the history

  6. ci: activate experimental string processing 

    https://black.readthedocs.io/en/stable/the_black_code_style/future_style.html#improved-string-processing
    @redeboer
    redeboer committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    420a5f4 View commit details
    Browse the repository at this point in the history

  7. style: apply experimental string processing to sympy/solvers

    @redeboer
    redeboer committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    0cdd862 View commit details
    Browse the repository at this point in the history

  8. fix: ignore mypy errors

    @redeboer
    redeboer committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    afee03a View commit details
    Browse the repository at this point in the history