Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention dockerfile in documentation style guide. #22733

Merged
merged 2 commits into from
Dec 28, 2021

Conversation

skieffer
Copy link
Member

References to other Issues or PRs

Closes #22708

Brief description of what is fixed or changed

Other comments

Release Notes

NO ENTRY

@sympy-bot
Copy link

Hi, I am the SymPy bot (v162). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.
Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->

Closes #22708 

#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

@github-actions
Copy link

github-actions bot commented Dec 21, 2021

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

       before           after         ratio
     [907895ac]       [6632ed8b]
-         218±1ms        132±0.6ms     0.60  large_exprs.TimeLargeExpressionOperations.time_subs
-       225±0.5μs        104±0.2μs     0.46  matrices.TimeMatrixExpression.time_MatMul
-     14.2±0.02ms      7.64±0.02ms     0.54  matrices.TimeMatrixExpression.time_MatMul_doit
-      4.11±0.02s          313±2ms     0.08  polygon.PolygonArbitraryPoint.time_bench01
+     3.31±0.02ms      5.69±0.03ms     1.72  solve.TimeMatrixOperations.time_det(4, 2)
+     3.30±0.01ms      5.70±0.02ms     1.73  solve.TimeMatrixOperations.time_det_bareiss(4, 2)
+      37.5±0.3ms       69.9±0.2ms     1.87  solve.TimeMatrixSolvePyDySlow.time_linsolve(1)
+      38.3±0.7ms       70.0±0.5ms     1.83  solve.TimeMatrixSolvePyDySlow.time_solve(1)

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@bertiewooster
Copy link
Contributor

Nice. Perhaps add a link to Docker’s web site, so people know how to download it.

@skieffer skieffer merged commit f7ca8b4 into sympy:master Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention dockerfile in documentation style guide
3 participants