Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cython future warning #22742

Merged
merged 2 commits into from Dec 22, 2021
Merged

Remove Cython future warning #22742

merged 2 commits into from Dec 22, 2021

Conversation

oscargus
Copy link
Contributor

References to other Issues or PRs

Brief description of what is fixed or changed

Fixes the following warning in optional dependency-tests by setting language_level to 3 if it is not explicitly set elsewhere:

/opt/hostedtoolcache/Python/3.9.9/x64/lib/python3.9/site-packages/Cython/Compiler/Main.py:369: FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2). This will change in a later release! File: /tmp/tmp4y6wzijg/_sigmoid.pyx

Other comments

Release Notes

  • utilities
    • language_level is automatically set to 3 when compiling with cython using utilities._compilation, but can be overridden by providing another language_level.

@sympy-bot
Copy link

sympy-bot commented Dec 22, 2021

Hi, I am the SymPy bot (v162). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • utilities
    • language_level is automatically set to 3 when compiling with cython using utilities._compilation, but can be overridden by providing another language_level. (#22742 by @oscargus and @sympy)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.10.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed

Fixes the following warning in optional dependency-tests by setting language_level to 3 if it is not explicitly set elsewhere:
```
/opt/hostedtoolcache/Python/3.9.9/x64/lib/python3.9/site-packages/Cython/Compiler/Main.py:369: FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2). This will change in a later release! File: /tmp/tmp4y6wzijg/_sigmoid.pyx
```

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* utilities
    * `language_level` is automatically set to 3 when compiling with cython using `utilities._compilation`, but can be overridden by providing another language_level.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@oscargus oscargus changed the title Remove Cython deprecation warning Remove Cython future warning Dec 22, 2021
@oscarbenjamin oscarbenjamin merged commit 6632ed8 into master Dec 22, 2021
@oscarbenjamin oscarbenjamin deleted the oscargus-patch-1 branch December 22, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants