Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct Piecewise simplification of expressions; improve condition handling #22751

Merged
merged 2 commits into from Dec 25, 2021

Conversation

smichr
Copy link
Member

@smichr smichr commented Dec 24, 2021

References to other Issues or PRs

fixes #22747

Brief description of what is fixed or changed

Other comments

Release Notes

  • functions
    • bug fixed for simplification of Piecewise expressions
    • condition of Piecewise which are univariate are made more canonical (redundant conditions removed)

@sympy-bot
Copy link

sympy-bot commented Dec 24, 2021

Hi, I am the SymPy bot (v162). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • functions
    • bug fixed for simplification of Piecewise expressions (#22751 by @smichr)

    • condition of Piecewise which are univariate are made more canonical (redundant conditions removed) (#22751 by @smichr)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.10.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->

fixes #22747

#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* functions
    * bug fixed for simplification of Piecewise expressions
    * condition of Piecewise which are univariate are made more canonical (redundant conditions removed)
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@github-actions
Copy link

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

       before           after         ratio
     [907895ac]       [6632ed8b]
-         230±6ms          136±2ms     0.59  large_exprs.TimeLargeExpressionOperations.time_subs
-      15.8±0.4ms       10.4±0.3ms     0.66  matrices.TimeMatrixExpression.time_MatAdd_doit
-         225±8μs          103±5μs     0.46  matrices.TimeMatrixExpression.time_MatMul
-      14.3±0.3ms      7.42±0.04ms     0.52  matrices.TimeMatrixExpression.time_MatMul_doit
+      6.77±0.1ms       10.2±0.4ms     1.51  matrices.TimeMatrixPower.time_Case1
-      4.60±0.01s          333±7ms     0.07  polygon.PolygonArbitraryPoint.time_bench01
+     3.53±0.07ms       6.21±0.1ms     1.76  solve.TimeMatrixOperations.time_det(4, 2)
+      3.58±0.1ms       5.96±0.3ms     1.66  solve.TimeMatrixOperations.time_det_bareiss(4, 2)
+        488±10ms          747±5ms     1.53  solve.TimeMatrixSolve.time_solve('GE')
+      39.5±0.6ms         77.6±3ms     1.96  solve.TimeMatrixSolvePyDySlow.time_linsolve(1)
+        40.4±3ms         78.9±3ms     1.95  solve.TimeMatrixSolvePyDySlow.time_solve(1)

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in Piecewise result
3 participants