New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed (LaTeX) printer issues #22772
Fixed (LaTeX) printer issues #22772
Conversation
✅ Hi, I am the SymPy bot (v162). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.10. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
Benchmark results from GitHub Actions Lower numbers are good, higher numbers are bad. A ratio less than 1 Significantly changed benchmark results (PR vs master) Significantly changed benchmark results (master vs previous release) before after ratio
[907895ac] [448e6188]
- 287±5ms 181±7ms 0.63 large_exprs.TimeLargeExpressionOperations.time_subs
- 273±10μs 124±4μs 0.46 matrices.TimeMatrixExpression.time_MatMul
- 17.4±0.5ms 9.64±0.2ms 0.55 matrices.TimeMatrixExpression.time_MatMul_doit
+ 7.94±0.07ms 12.6±1ms 1.59 matrices.TimeMatrixPower.time_Case1
- 5.43±0.03s 416±3ms 0.08 polygon.PolygonArbitraryPoint.time_bench01
+ 4.26±0.09ms 7.63±0.5ms 1.79 solve.TimeMatrixOperations.time_det(4, 2)
+ 4.19±0.1ms 7.52±0.5ms 1.80 solve.TimeMatrixOperations.time_det_bareiss(4, 2)
+ 609±10ms 932±8ms 1.53 solve.TimeMatrixSolve.time_solve('GE')
+ 503±10ms 762±30ms 1.52 solve.TimeMatrixSolve.time_solve_sym('GE')
+ 44.6±1ms 93.7±4ms 2.10 solve.TimeMatrixSolvePyDySlow.time_linsolve(1)
+ 45.3±1ms 90.8±3ms 2.00 solve.TimeMatrixSolvePyDySlow.time_solve(1)
Full benchmark results can be found as artifacts in GitHub Actions |
looks ok to me |
References to other Issues or PRs
Closes #20959
Closes #21758
Brief description of what is fixed or changed
Fixed two printing issues.
Other comments
One may argue if a MatrixSymbol with a ^ in it should be parenthesize or not (possible to just put {} around it).
Release Notes
FourierSeries
with zero sequence do not hang.MatrixSymbol
with ^ in name can be LaTeX-printed without errors.Adjoint
andTranspose
in LaTeX and pretty.