Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed (LaTeX) printer issues #22772

Merged
merged 3 commits into from Dec 31, 2021
Merged

Fixed (LaTeX) printer issues #22772

merged 3 commits into from Dec 31, 2021

Conversation

oscargus
Copy link
Contributor

@oscargus oscargus commented Dec 31, 2021

References to other Issues or PRs

Closes #20959
Closes #21758

Brief description of what is fixed or changed

Fixed two printing issues.

  • FourierSeries with 0 sequences do not hang (LaTeX and pretty).
  • MatrixSymbols with ^ in name with be parenthesized (and provide valid LaTeX-code).

Other comments

One may argue if a MatrixSymbol with a ^ in it should be parenthesize or not (possible to just put {} around it).

Release Notes

  • printing
    • LaTeX and pretty printing of FourierSeries with zero sequence do not hang.
    • MatrixSymbol with ^ in name can be LaTeX-printed without errors.
    • No superfluous parenthesis for Adjoint and Transpose in LaTeX and pretty.

@sympy-bot
Copy link

sympy-bot commented Dec 31, 2021

Hi, I am the SymPy bot (v162). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • printing
    • LaTeX and pretty printing of FourierSeries with zero sequence do not hang. (#22772 by @oscargus)

    • MatrixSymbol with ^ in name can be LaTeX-printed without errors. (#22772 by @oscargus)

    • No superfluous parenthesis for Adjoint and Transpose in LaTeX and pretty. (#22772 by @oscargus)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.10.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->

Closes #20959 
Closes #21758 

#### Brief description of what is fixed or changed

Fixed two printing issues.
* FourierSeries with 0 sequences do not hang (LaTeX and pretty).
* MatrixSymbols with ^ in name with be parenthesized (and provide valid LaTeX-code).

#### Other comments

One may argue if a MatrixSymbol with a ^ in it should be parenthesize or not (possible to just put {} around it).

#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* printing
   * LaTeX and pretty printing of `FourierSeries` with zero sequence do not hang.
   * `MatrixSymbol` with ^ in name can be LaTeX-printed without errors.
   * No superfluous parenthesis for `Adjoint` and `Transpose` in LaTeX and pretty.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@github-actions
Copy link

github-actions bot commented Dec 31, 2021

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

       before           after         ratio
     [907895ac]       [448e6188]
-         287±5ms          181±7ms     0.63  large_exprs.TimeLargeExpressionOperations.time_subs
-        273±10μs          124±4μs     0.46  matrices.TimeMatrixExpression.time_MatMul
-      17.4±0.5ms       9.64±0.2ms     0.55  matrices.TimeMatrixExpression.time_MatMul_doit
+     7.94±0.07ms         12.6±1ms     1.59  matrices.TimeMatrixPower.time_Case1
-      5.43±0.03s          416±3ms     0.08  polygon.PolygonArbitraryPoint.time_bench01
+     4.26±0.09ms       7.63±0.5ms     1.79  solve.TimeMatrixOperations.time_det(4, 2)
+      4.19±0.1ms       7.52±0.5ms     1.80  solve.TimeMatrixOperations.time_det_bareiss(4, 2)
+        609±10ms          932±8ms     1.53  solve.TimeMatrixSolve.time_solve('GE')
+        503±10ms         762±30ms     1.52  solve.TimeMatrixSolve.time_solve_sym('GE')
+        44.6±1ms         93.7±4ms     2.10  solve.TimeMatrixSolvePyDySlow.time_linsolve(1)
+        45.3±1ms         90.8±3ms     2.00  solve.TimeMatrixSolvePyDySlow.time_solve(1)

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@smichr
Copy link
Member

smichr commented Dec 31, 2021

looks ok to me

@smichr smichr merged commit b0b66d5 into sympy:master Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants