New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily disable pymc3 #22783
Temporarily disable pymc3 #22783
Conversation
✅ Hi, I am the SymPy bot (v162). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.
Click here to see the pull request description that was parsed.
|
The option is to limit NumPy to version 1.21.5. |
That would make sense if we expect that numpy might fix this. Is there a numpy issue for this? |
I'd say it is an aesara issue. Basically they try to read directly from a file rather than querying: |
Benchmark results from GitHub Actions Lower numbers are good, higher numbers are bad. A ratio less than 1 Significantly changed benchmark results (PR vs master) Significantly changed benchmark results (master vs previous release) before after ratio
[907895ac] [b0b66d55]
- 213±0.6ms 123±7ms 0.58 large_exprs.TimeLargeExpressionOperations.time_subs
- 219±0.5μs 104±0.2μs 0.48 matrices.TimeMatrixExpression.time_MatMul
- 14.1±0.02ms 7.63±0.1ms 0.54 matrices.TimeMatrixExpression.time_MatMul_doit
- 4.10±0.02s 310±2ms 0.08 polygon.PolygonArbitraryPoint.time_bench01
+ 3.29±0.01ms 5.31±0.4ms 1.61 solve.TimeMatrixOperations.time_det(4, 2)
+ 3.29±0.02ms 5.36±0.4ms 1.63 solve.TimeMatrixOperations.time_det_bareiss(4, 2)
+ 37.4±0.8ms 64.7±5ms 1.73 solve.TimeMatrixSolvePyDySlow.time_linsolve(1)
+ 38.1±0.7ms 65.1±4ms 1.71 solve.TimeMatrixSolvePyDySlow.time_solve(1)
Full benchmark results can be found as artifacts in GitHub Actions |
d22f03a
to
b3a7107
Compare
Pushing again with only pymc3 removed (should pass if the providers are updated with the new aesara)- |
Okay looks good to me based on comments elsewhere (#22780 (comment)) I'll merge this now We need to make sure to remember to enable this again once there is a new version of pymc that we can use (CC @brandonwillard). |
References to other Issues or PRs
Brief description of what is fixed or changed
Disable
aesara andpymc3 as there is a bug when combined with newest NumPy.Bug: aesara-devs/aesara#715Solution(?): aesara-devs/aesara#716Other comments
Release Notes
NO ENTRY