Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable pymc3 #22783

Merged
merged 1 commit into from Jan 2, 2022
Merged

Conversation

oscargus
Copy link
Contributor

@oscargus oscargus commented Jan 1, 2022

References to other Issues or PRs

Brief description of what is fixed or changed

Disable aesara and pymc3 as there is a bug when combined with newest NumPy.

Bug: aesara-devs/aesara#715
Solution(?): aesara-devs/aesara#716

Other comments

Release Notes

NO ENTRY

@sympy-bot
Copy link

sympy-bot commented Jan 1, 2022

Hi, I am the SymPy bot (v162). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.
Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed

Disable ~~aesara and~~ pymc3 as there is a bug when combined with newest NumPy.

~~Bug: https://github.com/aesara-devs/aesara/issues/715~~
~~Solution(?): https://github.com/aesara-devs/aesara/pull/716~~

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

@oscargus
Copy link
Contributor Author

oscargus commented Jan 1, 2022

The option is to limit NumPy to version 1.21.5.

@oscarbenjamin
Copy link
Contributor

The option is to limit NumPy to version 1.21.5.

That would make sense if we expect that numpy might fix this. Is there a numpy issue for this?

@oscargus
Copy link
Contributor Author

oscargus commented Jan 1, 2022

I'd say it is an aesara issue. Basically they try to read directly from a file rather than querying:

https://github.com/aesara-devs/aesara/blob/ff4b91dddede43d63d348bdec8fe1079932146b0/aesara/link/c/cmodule.py#L2625-L2646

@github-actions
Copy link

github-actions bot commented Jan 1, 2022

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

       before           after         ratio
     [907895ac]       [b0b66d55]
-       213±0.6ms          123±7ms     0.58  large_exprs.TimeLargeExpressionOperations.time_subs
-       219±0.5μs        104±0.2μs     0.48  matrices.TimeMatrixExpression.time_MatMul
-     14.1±0.02ms       7.63±0.1ms     0.54  matrices.TimeMatrixExpression.time_MatMul_doit
-      4.10±0.02s          310±2ms     0.08  polygon.PolygonArbitraryPoint.time_bench01
+     3.29±0.01ms       5.31±0.4ms     1.61  solve.TimeMatrixOperations.time_det(4, 2)
+     3.29±0.02ms       5.36±0.4ms     1.63  solve.TimeMatrixOperations.time_det_bareiss(4, 2)
+      37.4±0.8ms         64.7±5ms     1.73  solve.TimeMatrixSolvePyDySlow.time_linsolve(1)
+      38.1±0.7ms         65.1±4ms     1.71  solve.TimeMatrixSolvePyDySlow.time_solve(1)

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@oscargus oscargus changed the title Temporary disable aesara and pymc3 Temporarily disable pymc3 Jan 2, 2022
@oscargus
Copy link
Contributor Author

oscargus commented Jan 2, 2022

Pushing again with only pymc3 removed (should pass if the providers are updated with the new aesara)-

@oscarbenjamin
Copy link
Contributor

Okay looks good to me based on comments elsewhere (#22780 (comment))

I'll merge this now

We need to make sure to remember to enable this again once there is a new version of pymc that we can use (CC @brandonwillard).

@oscarbenjamin oscarbenjamin merged commit 7dbc2f4 into sympy:master Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants