-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made changes for better user-interpretation of series which are demonstrably divergent #22809
base: master
Are you sure you want to change the base?
Conversation
✅ Hi, I am the SymPy bot (v162). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.
Click here to see the pull request description that was parsed.
|
@faze-geek The tests are failing because of the another issue which has been fixed here #22200 by me . It's done from my side and needs review to merge , maybe @oscargus or @smichr can help us out with that ! I don't see your code is responsible for the error but yeah the changes you made would involve this to be done . On master we have
On my pr
|
Thanks for informing me about this . I looked into it and feel if it is a SymPy issue ,once #22200 is merged my failing checks will get resolved . |
c51fdd2
to
972c4ed
Compare
References to other Issues or PRs
Closes #14191
Brief description of what is fixed or changed
Modified :
concrete/summations.py
Modified :
concrete/tests/test_sums_products.py
Added code for required series which are known to be divergent but on master it returns
self
.So a converge check is added once the summation fails ,which is useful information for the user.Secondly anything constant should be treated as convergent .I observed that on master -
Here if 'x' was a number then on master the output is 'True'. The basic observation here was that cos(n) anyways will always stay bounded and hence cos(x) + cos(x+1) should be convergent.
After my commits -
This gives 'True' unless n is substituted
S.Infinity/oo
Other comments
I will be adding appropriate tests and look into the failed checks soon !
Release Notes
NO ENTRY