Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geometry - projection method returns EmptySet when there is no projection #22817

Merged
merged 2 commits into from Jan 7, 2022

Conversation

praneethratna
Copy link
Contributor

@praneethratna praneethratna commented Jan 7, 2022

References to other Issues or PRs

Brief description of what is fixed or changed

Partially Fixes #22807 and now projection method returns EmptySet when there is no projection of one entity onto another.

Other comments

Release Notes

  • geometry
    • projection method of line.py now returns EmptySet when there is no projection of one entity onto another.

@sympy-bot
Copy link

sympy-bot commented Jan 7, 2022

Hi, I am the SymPy bot (v162). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.10.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed
Partially Fixes #22807 and now `projection` method returns EmptySet when there is no projection of one entity onto another.

#### Other comments

#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* geometry
   * made changes to `line.py`.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@praneethratna
Copy link
Contributor Author

CC @smichr

@smichr
Copy link
Member

smichr commented Jan 7, 2022

Looks good.

@smichr smichr enabled auto-merge January 7, 2022 17:59
@smichr smichr merged commit c02ce2e into sympy:master Jan 7, 2022
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

       before           after         ratio
     [907895ac]       [bd841162]
-       215±0.7ms        133±0.7ms     0.62  large_exprs.TimeLargeExpressionOperations.time_subs
-         220±1μs        102±0.2μs     0.47  matrices.TimeMatrixExpression.time_MatMul
-     14.0±0.01ms      7.63±0.02ms     0.54  matrices.TimeMatrixExpression.time_MatMul_doit
-         4.05±0s          322±5ms     0.08  polygon.PolygonArbitraryPoint.time_bench01
+     3.29±0.01ms      5.64±0.02ms     1.71  solve.TimeMatrixOperations.time_det(4, 2)
+     3.29±0.01ms      5.65±0.01ms     1.72  solve.TimeMatrixOperations.time_det_bareiss(4, 2)
+     36.6±0.09ms       69.2±0.2ms     1.89  solve.TimeMatrixSolvePyDySlow.time_linsolve(1)
+      37.4±0.2ms       69.4±0.4ms     1.86  solve.TimeMatrixSolvePyDySlow.time_solve(1)

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@asmeurer
Copy link
Member

asmeurer commented Jan 7, 2022

Please write your release notes so that they make sense to an end-user reading the release notes file. "Made changes in line.py" is meaningless to someone who just wants to know what changed in the release. It's not even particularly helpful for people reviewing this PR.

@praneethratna
Copy link
Contributor Author

Please write your release notes so that they make sense to an end-user reading the release notes file. "Made changes in line.py" is meaningless to someone who just wants to know what changed in the release. It's not even particularly helpful for people reviewing this PR.

Sorry for that vague release note. I've updated the Release notes now which looks much better to the end user.

@praneethratna praneethratna deleted the geometry branch January 11, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

let some sort of EmptySet represent null object in geometry
4 participants