New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geometry - projection method returns EmptySet when there is no projection #22817
Conversation
✅ Hi, I am the SymPy bot (v162). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.10. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
CC @smichr |
Looks good. |
Benchmark results from GitHub Actions Lower numbers are good, higher numbers are bad. A ratio less than 1 Significantly changed benchmark results (PR vs master) Significantly changed benchmark results (master vs previous release) before after ratio
[907895ac] [bd841162]
- 215±0.7ms 133±0.7ms 0.62 large_exprs.TimeLargeExpressionOperations.time_subs
- 220±1μs 102±0.2μs 0.47 matrices.TimeMatrixExpression.time_MatMul
- 14.0±0.01ms 7.63±0.02ms 0.54 matrices.TimeMatrixExpression.time_MatMul_doit
- 4.05±0s 322±5ms 0.08 polygon.PolygonArbitraryPoint.time_bench01
+ 3.29±0.01ms 5.64±0.02ms 1.71 solve.TimeMatrixOperations.time_det(4, 2)
+ 3.29±0.01ms 5.65±0.01ms 1.72 solve.TimeMatrixOperations.time_det_bareiss(4, 2)
+ 36.6±0.09ms 69.2±0.2ms 1.89 solve.TimeMatrixSolvePyDySlow.time_linsolve(1)
+ 37.4±0.2ms 69.4±0.4ms 1.86 solve.TimeMatrixSolvePyDySlow.time_solve(1)
Full benchmark results can be found as artifacts in GitHub Actions |
Please write your release notes so that they make sense to an end-user reading the release notes file. "Made changes in |
Sorry for that vague release note. I've updated the Release notes now which looks much better to the end user. |
References to other Issues or PRs
Brief description of what is fixed or changed
Partially Fixes #22807 and now
projection
method returns EmptySet when there is no projection of one entity onto another.Other comments
Release Notes
projection
method ofline.py
now returns EmptySet when there is no projection of one entity onto another.