New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(solvers): handle factorisation better in solveset #23691
Conversation
✅ Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.11. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
76e0a78
to
6a80305
Compare
Benchmark results from GitHub Actions Lower numbers are good, higher numbers are bad. A ratio less than 1 Significantly changed benchmark results (PR vs master) Significantly changed benchmark results (master vs previous release) before after ratio
[77f1d79c] [39d5b7df]
<sympy-1.10.1^0>
+ 140±3ms 251±5ms 1.79 sum.TimeSum.time_doit
Full benchmark results can be found as artifacts in GitHub Actions |
This is waiting for review. This is a fix for a regression in 1.10 which is a release blocker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks! |
References to other Issues or PRs
Fixes #23318
Brief description of what is fixed or changed
Properly handle all factors of a factorisable equation in solveset. Previously the equation was factored but the separate factors were not subsequently solved.
Other comments
Release Notes