Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ordered swap symbols and dict #23703

Merged
merged 4 commits into from Jun 29, 2022
Merged

ordered swap symbols and dict #23703

merged 4 commits into from Jun 29, 2022

Conversation

smichr
Copy link
Member

@smichr smichr commented Jun 29, 2022

References to other Issues or PRs

Brief description of what is fixed or changed

Other comments

Release Notes

  • solvers
    • non-symbols are now replaced with symbols that sort in the same order as the original objects
    • returned dictionaries are sorted by keys so a solution is easier to find visually

@sympy-bot
Copy link

sympy-bot commented Jun 29, 2022

Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • solvers
    • non-symbols are now replaced with symbols that sort in the same order as the original objects (#23703 by @smichr)

    • returned dictionaries are sorted by keys so a solution is easier to find visually (#23703 by @smichr)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.11.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* solvers
  * non-symbols are now replaced with symbols that sort in the same order as the original objects
  * returned dictionaries are sorted by keys so a solution is easier to find visually
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@github-actions
Copy link

github-actions bot commented Jun 29, 2022

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

       before           after         ratio
     [77f1d79c]       [863aba8e]
     <sympy-1.10.1^0>                 
+      97.8±0.3ms        176±0.8ms     1.80  sum.TimeSum.time_doit

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@smichr smichr closed this Jun 29, 2022
@smichr smichr reopened this Jun 29, 2022
@smichr smichr enabled auto-merge June 29, 2022 18:14
@smichr smichr merged commit 89b31eb into sympy:master Jun 29, 2022
@oscarbenjamin
Copy link
Contributor

When changes are made but then reverted the commits should be squashed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants