Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for 1.11 release blocker issues #23717

Merged
merged 3 commits into from Jul 3, 2022

Conversation

oscarbenjamin
Copy link
Contributor

@oscarbenjamin oscarbenjamin commented Jul 2, 2022

References to other Issues or PRs

Fixes #23707
Fixes #23704
Partial fix for #23677

Brief description of what is fixed or changed

When unrad encounters an expression that is not a polynomial function of the contained radicals such as sqrt(x)*exp(t*sqrt(x)) it should give up.

Also a bug in Risch was fixed to handle empty subspaces.

A problem with numerical robustness in minpoly was also fixed.

Other comments

Release Notes

  • solvers
    • A bug that caused an AttributeError when solving some equations or evaluating some integrals with radicals was fixed.
  • integrals
    • A bug in the Risch integration algorithm was fixed. Previously certain integrals would fail with an exception if an intermediate step generated an empty subspace.
  • polys
    • Numerical calculations in minpoly were made more robust fixing a bug that failed to compute the minimal polynomial for certain complicated algebraic expressions.

@sympy-bot
Copy link

sympy-bot commented Jul 2, 2022

Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • integrals

    • A bug in the Risch integration algorithm was fixed. Previously certain integrals would fail with an exception if an intermediate step generated an empty subspace. (#23717 by @oscarbenjamin)
  • polys

    • Numerical calculations in minpoly were made more robust fixing a bug that failed to compute the minimal polynomial for certain complicated algebraic expressions. (#23717 by @oscarbenjamin)
  • solvers

    • A bug that caused an AttributeError when solving some equations or evaluating some integrals with radicals was fixed. (#23717 by @oscarbenjamin)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.11.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->

Fixes #23707
Fixes #23704
Partial fix for #23677

#### Brief description of what is fixed or changed

When `unrad` encounters an expression that is not a polynomial function of the contained radicals such as `sqrt(x)*exp(t*sqrt(x))` it should give up.

Also a bug in Risch was fixed to handle empty subspaces.

A problem with numerical robustness in `minpoly` was also fixed.

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* solvers
  * A bug that caused an AttributeError when solving some equations or evaluating some integrals with radicals was fixed.
* integrals
  * A bug in the Risch integration algorithm was fixed. Previously certain integrals would fail with an exception if an intermediate step generated an empty subspace.
* polys
  * Numerical calculations in `minpoly` were made more robust fixing a bug that failed to compute the minimal polynomial for certain complicated algebraic expressions.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@oscarbenjamin oscarbenjamin changed the title fix(solvers): better handling of nonpolys in unrad Various fixes for 1.11 release blocker issues Jul 2, 2022
@github-actions
Copy link

github-actions bot commented Jul 2, 2022

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

       before           after         ratio
     [77f1d79c]       [b64cfcdb]
     <sympy-1.10.1^0>                 
+      96.6±0.4ms        175±0.8ms     1.81  sum.TimeSum.time_doit

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@oscarbenjamin
Copy link
Contributor Author

This PR fixes 3 different release blocker issues that are all bugs and/or regressions.

Can someone review this?

@jksuom
Copy link
Member

jksuom commented Jul 3, 2022

Looks good.

@jksuom jksuom merged commit ab414d1 into sympy:master Jul 3, 2022
@oscarbenjamin oscarbenjamin deleted the pr_unrad branch July 3, 2022 11:13
@oscarbenjamin
Copy link
Contributor Author

Thanks @jksuom !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants