New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes for 1.11 release blocker issues #23717
Conversation
✅ Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.11. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
Benchmark results from GitHub Actions Lower numbers are good, higher numbers are bad. A ratio less than 1 Significantly changed benchmark results (PR vs master) Significantly changed benchmark results (master vs previous release) before after ratio
[77f1d79c] [b64cfcdb]
<sympy-1.10.1^0>
+ 96.6±0.4ms 175±0.8ms 1.81 sum.TimeSum.time_doit
Full benchmark results can be found as artifacts in GitHub Actions |
This PR fixes 3 different release blocker issues that are all bugs and/or regressions. Can someone review this? |
Looks good. |
Thanks @jksuom ! |
References to other Issues or PRs
Fixes #23707
Fixes #23704
Partial fix for #23677
Brief description of what is fixed or changed
When
unrad
encounters an expression that is not a polynomial function of the contained radicals such assqrt(x)*exp(t*sqrt(x))
it should give up.Also a bug in Risch was fixed to handle empty subspaces.
A problem with numerical robustness in
minpoly
was also fixed.Other comments
Release Notes
minpoly
were made more robust fixing a bug that failed to compute the minimal polynomial for certain complicated algebraic expressions.