Avoid exponential time complexity in codeprinter

[bjodah]

References to other Issues or PRs

Fixes #23839

Brief description of what is fixed or changed

There is no need to try to call a python string. Previously work was done to parenthesize the arguments even though it could be determined that this work was in vain.

Other comments

I wouldn't be surprised if it's possible to construct other pathogenic expressions exhibiting exponential runtime. But this fix should nevertheless be harmless.

cc @eschnett, does this help for your real world use case as well?

Release Notes

• printing
  • Better performance when passing user_functions to the printers.

[sympy-bot]

✅

Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

• printing
  • Better performance when passing user_functions to the printers. (#23841 by @bjodah)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.12.

Click here to see the pull request description that was parsed.

#### References to other Issues or PRs
Fixes #23839


#### Brief description of what is fixed or changed
There is no need to try to call a python string. Previously work was done to parenthesize the arguments even though it could be determined that this work was in vain.

#### Other comments
I wouldn't be surprised if it's possible to construct other pathogenic expressions exhibiting exponential runtime. But this fix should nevertheless be harmless.

cc @eschnett, does this help for your real world use case as well?

#### Release Notes
<!-- BEGIN RELEASE NOTES -->
* printing
  * Better performance when passing `user_functions` to the printers.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

[github-actions]

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

[oscarbenjamin]

Looks good.